Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): unified installation of metrics/logging/tracing into one command observability #4308

Merged
merged 10 commits into from
May 23, 2022
70 changes: 3 additions & 67 deletions app/kumactl/cmd/completion/testdata/bash.golden
Original file line number Diff line number Diff line change
Expand Up @@ -3775,40 +3775,9 @@ _kumactl_install_gateway()
noun_aliases=()
}

_kumactl_install_logging()
_kumactl_install_observability()
{
last_command="kumactl_install_logging"

command_aliases=()

commands=()

flags=()
two_word_flags=()
local_nonpersistent_flags=()
flags_with_completion=()
flags_completion=()

flags+=("--namespace=")
two_word_flags+=("--namespace")
local_nonpersistent_flags+=("--namespace")
local_nonpersistent_flags+=("--namespace=")
flags+=("--api-timeout=")
two_word_flags+=("--api-timeout")
flags+=("--config-file=")
two_word_flags+=("--config-file")
flags+=("--log-level=")
two_word_flags+=("--log-level")
flags+=("--no-config")

must_have_one_flag=()
must_have_one_noun=()
noun_aliases=()
}

_kumactl_install_metrics()
{
last_command="kumactl_install_metrics"
last_command="kumactl_install_observability"

command_aliases=()

Expand Down Expand Up @@ -3856,37 +3825,6 @@ _kumactl_install_metrics()
noun_aliases=()
}

_kumactl_install_tracing()
{
last_command="kumactl_install_tracing"

command_aliases=()

commands=()

flags=()
two_word_flags=()
local_nonpersistent_flags=()
flags_with_completion=()
flags_completion=()

flags+=("--namespace=")
two_word_flags+=("--namespace")
local_nonpersistent_flags+=("--namespace")
local_nonpersistent_flags+=("--namespace=")
flags+=("--api-timeout=")
two_word_flags+=("--api-timeout")
flags+=("--config-file=")
two_word_flags+=("--config-file")
flags+=("--log-level=")
two_word_flags+=("--log-level")
flags+=("--no-config")

must_have_one_flag=()
must_have_one_noun=()
noun_aliases=()
}

_kumactl_install_transparent-proxy()
{
last_command="kumactl_install_transparent-proxy"
Expand Down Expand Up @@ -3983,9 +3921,7 @@ _kumactl_install()
commands+=("crds")
commands+=("demo")
commands+=("gateway")
commands+=("logging")
commands+=("metrics")
commands+=("tracing")
commands+=("observability")
commands+=("transparent-proxy")

flags=()
Expand Down
4 changes: 1 addition & 3 deletions app/kumactl/cmd/install/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ func NewInstallCmd(pctx *kumactl_cmd.RootContext) *cobra.Command {
// sub-commands
cmd.AddCommand(newInstallControlPlaneCmd(&pctx.InstallCpContext))
cmd.AddCommand(newInstallCrdsCmd(&pctx.InstallCRDContext))
cmd.AddCommand(newInstallMetrics(pctx))
cmd.AddCommand(newInstallTracing(pctx))
cmd.AddCommand(newInstallLogging(pctx))
cmd.AddCommand(newInstallObservability(pctx))
cmd.AddCommand(newInstallDemoCmd(&pctx.InstallDemoContext))
cmd.AddCommand(newInstallGatewayCmd(pctx))
cmd.AddCommand(newInstallTransparentProxy())
Expand Down
53 changes: 0 additions & 53 deletions app/kumactl/cmd/install/install_logging.go

This file was deleted.

68 changes: 0 additions & 68 deletions app/kumactl/cmd/install/install_logging_test.go

This file was deleted.

121 changes: 0 additions & 121 deletions app/kumactl/cmd/install/install_metrics.go

This file was deleted.

Loading