Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cni): use our cni with calico #4801

Merged
merged 5 commits into from
Aug 12, 2022

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 10, 2022

A PR showing that our CNI works with calico CNI, it is not meant to be a replacement for flannel. The idea here is to show how I will generally look which means:

  • a new target to start k3d with calico
  • some minor adjustments in the e2e config and tests
  • some tests (probably taint container ones) will be run twice, once with flannel (the way it's run now) and once with calico (the thing we want to test)

Closes #4648

Signed-off-by: slonka slonka@users.noreply.github.com

Checklist prior to review

  • Link to docs PR or issue -- more test coverage - no need for docs PR
  • Link to UI issue or PR -- not ui issue
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests -- not relevant
  • E2E Tests -- added more e2e tests coverage
  • Manual Universal Tests -- not relevant
  • Manual Kubernetes Tests -- not relevant
  • Do you need to update UPGRADE.md? -- no need
  • Does it need to be backported according to the backporting policy? -- no need

Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka force-pushed the feat/support-for-3rd-party-cni branch from a02c60c to 60b1816 Compare August 10, 2022 15:13
mk/k3d.mk Outdated Show resolved Hide resolved
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Aug 11, 2022
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka force-pushed the feat/support-for-3rd-party-cni branch from 1be377e to 008b4b6 Compare August 11, 2022 08:58
slonka added 3 commits August 11, 2022 14:07
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@mergify mergify bot mentioned this pull request Aug 12, 2022
11 tasks
@slonka slonka changed the title feat(cni): use our cni with calico - working locally only feat(cni): use our cni with calico Aug 12, 2022
@slonka
Copy link
Contributor Author

slonka commented Aug 12, 2022

the same commit already passed but I'm running it again to look for flakes https://app.circleci.com/pipelines/github/kumahq/kuma?branch=pull%2F4804

@slonka slonka marked this pull request as ready for review August 12, 2022 09:12
@slonka slonka requested a review from a team as a code owner August 12, 2022 09:12
@slonka slonka enabled auto-merge (squash) August 12, 2022 09:34
@slonka slonka merged commit 67578a6 into kumahq:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for calico CNI along with ours
2 participants