Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] do not merge #4804

Closed

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Aug 11, 2022

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --

slonka added 4 commits August 10, 2022 17:13
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: slonka <slonka@users.noreply.github.com>
@slonka slonka added the ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully) label Aug 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4804 (d329dc0) into master (6cb5de9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4804      +/-   ##
==========================================
- Coverage   46.45%   46.44%   -0.01%     
==========================================
  Files         690      690              
  Lines       47113    47113              
==========================================
- Hits        21884    21883       -1     
- Misses      23300    23302       +2     
+ Partials     1929     1928       -1     
Impacted Files Coverage Δ
pkg/core/resources/manager/cache.go 85.71% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 89.77% <0.00%> (-1.14%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 71.79% <0.00%> (+5.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: slonka <slonka@users.noreply.github.com>
@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2022

⚠️ The sha of the head commit of this PR conflicts with #4801. Mergify cannot evaluate rules on this PR. ⚠️

@slonka slonka closed this Aug 12, 2022
@slonka
Copy link
Contributor Author

slonka commented Aug 12, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-full-matrix PR: Runs all possible e2e test combination (expensive use carefully)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants