Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(MeshAccessLog): don't log on inbound passthrough listeners #5177

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore(MeshAccessLog): don't log on inbound passthrough listeners #5177

merged 1 commit into from
Oct 19, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Oct 19, 2022 •
edited by lukidzi
Loading

Rationale being that there's no way to even specify from rules that would match traffic sent over the inbound listener. Mesh doesn't apply, MeshService doesn't apply, etc.

Does this make sense to people?

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): Add MeshAccessLog policy

@michaelbeaumont
chore: don't log on inbound listeners
c23b125 
Rationale being that there's no way to _specify_ `from` rules that would
match traffic sent over the inbound listener.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner October 19, 2022 14:28
@michaelbeaumont michaelbeaumont changed the title chore: don't log on inbound listeners chore(MeshAccessLog): don't log on inbound listeners Oct 19, 2022
@michaelbeaumont michaelbeaumont changed the title chore(MeshAccessLog): don't log on inbound listeners chore(MeshAccessLog): don't log on inbound passthrough listeners Oct 19, 2022
@michaelbeaumont michaelbeaumont merged commit fd91403 into kumahq:master Oct 19, 2022
@michaelbeaumont michaelbeaumont deleted the chore/meshaccesslog_no_inbound branch October 19, 2022 15:51
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @lahabana