fix5383 #79
Closed
fix5383 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For some reason we're not getting this as maintainer in the env var - See for deprecation: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Signed-off-by: Charly Molter <charly.molter@konghq.com>
…q#5146) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.21.1 to 1.22.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.21.1...v1.22.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
….40.24 (kumahq#5162) chore(deps): bump github.com/gruntwork-io/terratest Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.22 to 0.40.24. - [Release notes](https://github.com/gruntwork-io/terratest/releases) - [Commits](gruntwork-io/terratest@v0.40.22...v0.40.24) --- updated-dependencies: - dependency-name: github.com/gruntwork-io/terratest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.8 to 0.4.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.8...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…33ddc456 (kumahq#5167) Bumps kumahq/kuma-gui to version [master@82343903a040efd14366441ea4e1a46833ddc456](https://github.com/kumahq/kuma-gui/tree/82343903a040efd14366441ea4e1a46833ddc456) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
* feat: support JSON with MeshAccessLog * feat(kuma-dp): support log messages embedded as JSON * test(e2e): add JSON to MeshAccessLog tests * chore: add comment why we try 2 methods for parsing Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
…5159) * feat(kuma-dp): publish metrics with text_readouts from envoy When publishing metrics with text_readouts we can add grafana dashboard to dataplane view with information to which CP this DP was connected at given time, it is especially useful when debugging. Fixes: kumahq#1011 Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
- Worked on reducing 2 existing flakiness Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
…umahq#5175) * chore(deps): update gateway-api * fix: properly set ResolvedRefs listener condition * fix: properly set SupportedKinds * test(e2e): reenable Gateway API conformance tests * refactor: use beta types where possible * refactor: no more deprecated conditions Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…ahq#5177) Rationale being that there's no way to _specify_ `from` rules that would match traffic sent over the inbound passthrough listener. Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…umahq#5176) - meshtrace and trace tests were using the same namespace/mesh - healthcheck test is flaky with curl exit code 52, it's not super clear what happens so rewrote the test in a way that may bubble error more clearly to figure out what's wrong Signed-off-by: Charly Molter <charly.molter@konghq.com>
…6d47807a (kumahq#5179) Bumps kumahq/kuma-gui to version [master@55b4554a0a8278788f9cbacc70d0c0e76d47807a](https://github.com/kumahq/kuma-gui/tree/55b4554a0a8278788f9cbacc70d0c0e76d47807a) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…ahq#5095) Signed-off-by: Bart Smykla <bartek@smykla.com> Co-authored-by: Łukasz Dziedziak <lukidzi@gmail.com>
…umahq#5187) Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
* fix(kumactl): get APIVersions from k8s server This wasn't being set correctly when using actual clusters so .Capabilities.APIVersions in templates wasn't working correctly with kumactl. Which meant that the GatewayClass in the templates wasn't ever created, even if Gateway API CRDs are in the cluster. This code is more or less directly inlined from helm because these aren't public functions. * test(e2e): use default GatewayClass with Gateway API * test(e2e): wait for gateway API webhooks * test(kumactl): add --without-kubernetes-connection We aren't using an actual cluster in these tests * test(e2e): wait for gateway API webhooks in conformance tests * test(e2e): use t.Cleanup instead of defer Using defer was causing the GatewayClass to be deleted before the Gateways, which left a finalizer on the GatewayClass, which made `DeleteKuma` hang. * chore: add docs about inlined functions Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
* feat: add crossMesh to MeshGatewayConfig * test(gatewayapi): add validation test * feat(helm): add MeshGatewayConfig with crossMesh: true * test(gatewayapi): remove deprecated condition * test(kumactl): update CRDs * Revert "feat(helm): add MeshGatewayConfig with crossMesh: true" This reverts commit 1e95f6f. It's not possible to install CRDs and create CRs at the same time with `kumactl | kubectl` so this will be handled in another PR. * test(e2e): add crossMesh Gateway API Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
- disallow setting name with `kind: Mesh` as it's unclear what it will mean - disallow setting mesh with all kinds as it's unclear what it will mean too - disallow using `MeshHTTPRoute` the thing is not even defined - rewrite validator for targetRef to use the same wording everwhere Fix kumahq#5165 Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
…umahq#5186) * feat(kuma-cp): add possibility to restrict TLS version and ciphers Add options to set the list of ciphers and the minimum/maximum TLS version supported also set min version to 1.2 by default. Fix kumahq#5170 Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
…ahq#5185) * feat(kumacp): multiple external services pointing to same address Allow using multiple external services pointing to same address by adding a flag to disable automatic host DNS entry. Signed-off-by: slonka <slonka@users.noreply.github.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
* docs(madr): add new MeshCircuitBreaker policy Signed-off-by: Bart Smykla <bartek@smykla.com>
* feat(policy): mesh health check api and validator Signed-off-by: slonka <slonka@users.noreply.github.com> Co-authored-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Bart Smykla <bartek@smykla.com> Signed-off-by: Bart Smykla <bartek@smykla.com>
Also suppress unituitive api override endpoint for open-core implementation. Now basedOnKuma is always there it's just not set when using Kuma and won't be displayed in api calls Signed-off-by: Charly Molter <charly.molter@konghq.com>
* chore(helm): use dummy chart versions * chore: update golden files Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.4.0 to 0.5.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.2.0 to 0.4.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.2.0...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This will make auto assign nicer Signed-off-by: Charly Molter <charly.molter@konghq.com>
…0.5 (kumahq#5456) Bumps [github.com/prometheus/prometheus](https://github.com/prometheus/prometheus) from 0.40.3 to 0.40.5. - [Release notes](https://github.com/prometheus/prometheus/releases) - [Changelog](https://github.com/prometheus/prometheus/blob/main/CHANGELOG.md) - [Commits](prometheus/prometheus@v0.40.3...v0.40.5) --- updated-dependencies: - dependency-name: github.com/prometheus/prometheus dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…0 to 0.9.1 (kumahq#5460) chore(deps): bump github.com/envoyproxy/protoc-gen-validate Bumps [github.com/envoyproxy/protoc-gen-validate](https://github.com/envoyproxy/protoc-gen-validate) from 0.9.0 to 0.9.1. - [Release notes](https://github.com/envoyproxy/protoc-gen-validate/releases) - [Changelog](https://github.com/bufbuild/protoc-gen-validate/blob/main/.goreleaser.yaml) - [Commits](bufbuild/protoc-gen-validate@v0.9.0...v0.9.1) --- updated-dependencies: - dependency-name: github.com/envoyproxy/protoc-gen-validate dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…kumahq#5457) Bumps [github.com/Masterminds/sprig/v3](https://github.com/Masterminds/sprig) from 3.2.2 to 3.2.3. - [Release notes](https://github.com/Masterminds/sprig/releases) - [Changelog](https://github.com/Masterminds/sprig/blob/master/CHANGELOG.md) - [Commits](Masterminds/sprig@v3.2.2...v3.2.3) --- updated-dependencies: - dependency-name: github.com/Masterminds/sprig/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
* feat: introduce MeshCircuitBreaker api Signed-off-by: Bart Smykla <bartek@smykla.com>
…9570dbc7 (kumahq#5405) Bumps kumahq/kuma-gui to version [master@926aa150c2b8b2e966db98e1c4374a949570dbc7](https://github.com/kumahq/kuma-gui/tree/926aa150c2b8b2e966db98e1c4374a949570dbc7) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…182c302f (kumahq#5484) Bumps kumahq/kuma-gui to version [master@3c2e6f7d3dca38162f419fe2b103a861182c302f](https://github.com/kumahq/kuma-gui/tree/3c2e6f7d3dca38162f419fe2b103a861182c302f) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
…umahq#5483) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.37.0 to 0.38.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.37.0...v0.38.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
…ca96b319 (kumahq#5486) Bumps kumahq/kuma-gui to version [master@c101ba41d3deedb293c26b2d988ba71fca96b319](https://github.com/kumahq/kuma-gui/tree/c101ba41d3deedb293c26b2d988ba71fca96b319) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* feat(kuma-cp): implement MeshTimeout policy Fixes: kumahq#5267 Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
It's redudundant and makes the response very big. It was also not very straight forward with new and old policy While this is a breaking change, we strictly remove things which shouldn't be an issue (kumactl was already not showing this) Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GatewayClassref doesn't exist (fix(gatewayapi): don't NPE if theGatewayClassref doesn't exist kumahq/kuma#5187)crossMeshtoMeshGatewayConfig(feat(gateway): addcrossMeshtoMeshGatewayConfigkumahq/kuma#5183)ExternalServicewithMeshAccessLog(test(e2e): addExternalServicewithMeshAccessLogkumahq/kuma#5237)MeshGatewaysupport (feat(MeshTrace):MeshGatewaysupport kumahq/kuma#5243)MeshGatewayRoutevalidation (docs(UPGRADE.md): add note aboutMeshGatewayRoutevalidation kumahq/kuma#5300)sslsniin universal (fix(kuma-cp): add option to disablesslsniin universal kumahq/kuma#5318)kumactl apply(fix(kumactl): use the same client inkumactl applykumahq/kuma#5327):(fix(api-server): fix tags filter value with:kumahq/kuma#5339)/tokens(chore(deps): update to emicklei/go-restful/v3 v3.10.1 and remove/tokenskumahq/kuma#5324).mergify.yml(ci: remove unused rule from.mergify.ymlkumahq/kuma#5370)kuma.io/meshlabel (feat(MeshGatewayInstance): respectkuma.io/meshlabel kumahq/kuma#5256)targetRef-based routing proposal (docs(MADR):targetRef-based routing proposal kumahq/kuma#5337)