Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): policy origin in rules #5184

Merged
merged 2 commits into from
Oct 20, 2022
Merged

feat(kuma-cp): policy origin in rules #5184

merged 2 commits into from
Oct 20, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Oct 20, 2022 •
edited by lukidzi
Loading

Implement policy origin in rules so we can expose this in inspect API.

Checklist prior to review

  • Link to docs PR or issue -- no
  • Link to UI issue or PR -- no
  • Is the issue worked on linked? -- no
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --no
  • Does it need to be backported according to the backporting policy? -- no
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests? no

Changelog: feat(inspect): implement rule-based view for new policies

@jakubdyszkiewicz
feat(kuma-cp): implement origin in rules
ad500be 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 20, 2022 14:41
lobkovilya
lobkovilya reviewed Oct 20, 2022
View reviewed changes
pkg/core/xds/rules.go Outdated Show resolved Hide resolved
@jakubdyszkiewicz
chore: use resource key as map key
f5d27bf 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) October 20, 2022 14:59
@jakubdyszkiewicz jakubdyszkiewicz merged commit 2259d7b into kumahq:master Oct 20, 2022
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubdyszkiewicz @lobkovilya