Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove protos for new policies #5218

Merged
merged 27 commits into from
Nov 2, 2022
Merged

chore: remove protos for new policies #5218

merged 27 commits into from
Nov 2, 2022

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Oct 26, 2022 •
edited by lukidzi
Loading

Current PR rewrites new policies using plain Go struct instead of protobuf.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- get rid of protos for new policies #5088
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: chore(proto): remove protos for new policies

@lobkovilya
chore: create generator, replace protos for MeshTrafficPermission
b6bfcc3 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: rewrite policies
066e927 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: make check
03560ba 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: make test
e0aa907 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: remove old generator
643d633 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into chore/remove-protos
a1d3232 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/api-server/inspect_endpoints_test.go
#	pkg/core/xds/rules.go
#	pkg/core/xds/rules_test.go
#	pkg/plugins/policies/meshaccesslog/plugin/v1alpha1/plugin.go
@lobkovilya
chore: make check
6af3498 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: remove 'DENY_WITH_SHADOW_ALLOW' from tests
02c7bbf 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into chore/remove-protos
75b872c 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present-not-enabled.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml
#	app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
#	app/kumactl/cmd/install/testdata/install-crds.all.golden.yaml
#	app/kumactl/cmd/install/testdata/install-crds.experimental-gatewayapi.golden.yaml
#	deployments/charts/kuma/crds/kuma.io_meshtrafficpermissions.yaml
#	pkg/core/resources/model/rest/list_test.go
#	pkg/core/xds/rules_test.go
#	pkg/plugins/policies/meshaccesslog/plugin/v1alpha1/plugin.go
#	pkg/plugins/policies/meshtrafficpermission/api/v1alpha1/meshtrafficpermission.pb.go
#	pkg/plugins/policies/meshtrafficpermission/api/v1alpha1/meshtrafficpermission.proto
#	pkg/plugins/policies/meshtrafficpermission/api/v1alpha1/schema.yaml
#	pkg/plugins/policies/meshtrafficpermission/k8s/crd/kuma.io_meshtrafficpermissions.yaml
@lobkovilya lobkovilya marked this pull request as ready for review October 26, 2022 14:29
@lobkovilya lobkovilya requested a review from a team as a code owner October 26, 2022 14:29
@lahabana lahabana linked an issue Oct 26, 2022 that may be closed by this pull request
get rid of protos for new policies #5088
Closed
@lobkovilya
chore: remove typeDesc from util methods
5a7fd1a 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: simplify getter generator
55cea0c 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
lahabana
lahabana reviewed Oct 27, 2022
View reviewed changes
api/common/v1alpha1/targetref.go Outdated Show resolved Hide resolved
api/common/v1alpha1/targetref.go Outdated Show resolved Hide resolved
api/common/v1alpha1/targetref.go Show resolved Hide resolved
api/common/v1alpha1/targetref.go Outdated Show resolved Hide resolved
api/common/v1alpha1/targetref.go Outdated Show resolved Hide resolved
pkg/plugins/policies/donothingpolicy/api/v1alpha1/validator.go Outdated Show resolved Hide resolved
pkg/core/resources/apis/mesh/mesh_suit_test.go Show resolved Hide resolved
pkg/plugins/policies/meshaccesslog/api/v1alpha1/meshaccesslog.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshaccesslog/api/v1alpha1/meshaccesslog.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshaccesslog/api/v1alpha1/meshaccesslog.go Outdated Show resolved Hide resolved
@lobkovilya
chore: review
5ba6b6b 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: remove getters, replace pointers with values
c8e7467 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: remove getter gen
cd4c685 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: remove nullable for 'from/to'
89119d3 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: fix typo in file name
f6ad262 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: move targetref
36a34fe 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: conf isn't a pointer
354e01a 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: update policy bootstrap
a4c34de 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into chore/remove-protos
1112199
lahabana
lahabana reviewed Oct 31, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
pkg/plugins/policies/matchers/match_test.go Outdated Show resolved Hide resolved
pkg/plugins/policies/matchers/validators/validator.go Show resolved Hide resolved
@lobkovilya
chore: review
5db2418 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: make check
72afe4d 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
Merge branch 'master' into chore/remove-protos
882d59a
lahabana
lahabana approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but LGTM

.golangci.yml Show resolved Hide resolved
pkg/core/xds/testdata/rules/06.golden.yaml Outdated Show resolved Hide resolved
pkg/plugins/policies/meshaccesslog/api/v1alpha1/zz_generated.helpers.go Outdated Show resolved Hide resolved
tools/policy-gen/generator/cmd/helpers.go Outdated Show resolved Hide resolved
tools/policy-gen/generator/cmd/helpers.go Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
@lobkovilya @lahabana
Apply suggestions from code review
dfe5f2c 
Co-authored-by: Charly Molter <charly@molter.io>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
@lobkovilya
Merge branch 'master' into chore/remove-protos
126f77a
@lobkovilya
chore: make check
395f9cb 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
chore: remove space in golden file
96eb3d7 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit db9de2b into kumahq:master Nov 2, 2022
@lobkovilya lobkovilya deleted the chore/remove-protos branch November 2, 2022 16:11
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get rid of protos for new policies
2 participants
@lobkovilya @lahabana