Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp): reissue admin tls cert on dp address change #5222

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix(kuma-cp): reissue admin tls cert on dp address change #5222

merged 2 commits into from
Oct 27, 2022

Conversation

jakubdyszkiewicz
Copy link
Contributor

Admin TLS certs were issued once. We need to reissue it when DP address changes.

Fix #5221

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- Envoy Admin mTLS certs should be regenerated on DP address change #5221
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests -- no, hard to execute
  • Manual Universal Tests -- no, hard to execute
  • Manual Kubernetes Tests -- no, hard to execute
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? -- although this is a bug, I don't think it qualifies for backporting.
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@jakubdyszkiewicz
fix(kuma-cp): reissue admin tls cert on dp address change
0c908b0 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 27, 2022 09:53
@jakubdyszkiewicz
chore: add a comment
590cc8b 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz merged commit b428b50 into kumahq:master Oct 27, 2022
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/reissue-cert-on-dp-address-change branch October 27, 2022 12:27
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana left review comments

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Envoy Admin mTLS certs should be regenerated on DP address change
3 participants
@jakubdyszkiewicz @lahabana @bartsmykla