Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MeshTrace): MeshGateway support #5243

Merged
merged 2 commits into from
Nov 2, 2022
Merged

feat(MeshTrace): MeshGateway support #5243

merged 2 commits into from
Nov 2, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 1, 2022 •
edited by lukidzi
Loading

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? -- Closes MeshTrace with MeshGateway #5231
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests -- none
  • E2E Tests --
  • Manual Universal Tests -- none
  • Manual Kubernetes Tests -- none
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): Add MeshTrace policy

@michaelbeaumont
feat(MeshTrace): MeshGateway support
01d7df2 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 1, 2022 13:17
@michaelbeaumont michaelbeaumont changed the title feat(MeshTrace): MeshGateway support feat(MeshTrace): MeshGateway support Nov 1, 2022
@michaelbeaumont
test(e2e): MeshGateway and MeshTrace
f9fe19a 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) November 1, 2022 22:31
slonka
slonka reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some questions:

  1. Should we add a unit test
  2. Why are we not adding a k8s test?

test/e2e_env/universal/observability/meshtrace.go Show resolved Hide resolved
test/e2e_env/universal/observability/meshtrace.go Show resolved Hide resolved
@michaelbeaumont
Copy link
Contributor Author

I can

  • Why are we not adding a k8s test?

I don't understand the reason we have both for these plugins in the first place actually. Does their behavior depend on whether we're using k8s or universal?

@slonka
Copy link
Contributor

slonka commented Nov 2, 2022

I don't understand the reason we have both for these plugins in the first place actually. Does their behavior depend on whether we're using k8s or universal?

Yeah, was wondering the same. Tracked it down to this PR https://github.com/kumahq/kuma/pull/930/files - maybe @lobkovilya remembers (Jakub is OOO).

@lahabana
Copy link
Contributor

lahabana commented Nov 2, 2022

Yeah I don't see the value of having e2e tests for both platforms if there's no practical difference in the implem.

@michaelbeaumont michaelbeaumont merged commit 991ca34 into kumahq:master Nov 2, 2022
@michaelbeaumont michaelbeaumont deleted the feat/trace_gateway branch November 2, 2022 10:28
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slonka slonka slonka left review comments

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshTrace with MeshGateway
3 participants
@michaelbeaumont @slonka @lahabana