Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshGatewayInstance): respect kuma.io/mesh label #5256

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 2, 2022

This is more in line with the plans for targetRef policies.

We need to decide on whether to move to labels everywhere (i.e. Pods/Namespaces)!

Checklist prior to review

@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_instance_mesh_label branch from 1eb72fe to 924e690 Compare November 2, 2022 20:19
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont force-pushed the feat/gateway_instance_mesh_label branch from 924e690 to cd3a613 Compare November 21, 2022 15:31
@michaelbeaumont michaelbeaumont marked this pull request as ready for review November 22, 2022 12:25
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 22, 2022 12:25
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@lahabana
Copy link
Contributor

What's the story here @michaelbeaumont ?

@michaelbeaumont
Copy link
Contributor Author

No story really 😃, just a PR to make MeshGatewayInstance more like new policies

@michaelbeaumont michaelbeaumont merged commit c86dd05 into kumahq:master Dec 5, 2022
@michaelbeaumont michaelbeaumont deleted the feat/gateway_instance_mesh_label branch December 5, 2022 14:42
@lahabana lahabana mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants