Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): concurrent mesh cache map write #5282

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Nov 8, 2022

Advantage over #5252 and the alternative there being that locking is handled by the data structure, the expirationTime time check is handled by the data structure and this eventually cleans up unused meshes.

Closes #5245
Closes #4282

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner November 8, 2022 13:10
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@bartsmykla
Copy link
Contributor

@michaelbeaumont could we merge this PR?

@michaelbeaumont
Copy link
Contributor Author

Maybe @lobkovilya can take a look again too?

@michaelbeaumont michaelbeaumont merged commit 86d2db9 into kumahq:master Nov 14, 2022
@michaelbeaumont michaelbeaumont deleted the fix/mesh_cache_2 branch November 14, 2022 10:47
@lahabana lahabana mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kuma-cp concurrent map write Cleanup mesh contexts after Mesh deletion
4 participants