Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): implement meshtimeout policy api + validation #5294

Merged
merged 15 commits into from
Nov 21, 2022
Merged

feat(kuma-cp): implement meshtimeout policy api + validation #5294

merged 15 commits into from
Nov 21, 2022

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Nov 10, 2022 •
edited by lahabana
Loading

Fixes: #5267

Signed-off-by: Marcin Skalski marcin.skalski@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshTimeout policy

@Automaat
feat(kuma-cp): Implement MeshTimeout policy api
7a89acc 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested a review from a team as a code owner November 10, 2022 08:55
@Automaat Automaat changed the title feat(kuma-cp): Implement MeshTimeout policy api feat(kuma-cp): implement meshtimeout policy api + validation Nov 10, 2022
lobkovilya
lobkovilya reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@lobkovilya lobkovilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like validation tests are broken because of the check against the OpenAPI schema

pkg/plugins/policies/meshtimeout/api/v1alpha1/meshtimeout.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/api/v1alpha1/meshtimeout.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/api/v1alpha1/meshtimeout.go Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/api/v1alpha1/meshtimeout.go Show resolved Hide resolved
@Automaat
feat(kuma-cp): fixed failing tests^
978f001 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): fixed types
b978e23 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into feat/meshtimeout_api
9cb18e0
@Automaat
Merge remote-tracking branch 'origin/feat/meshtimeout_api' into feat/…
3bc9ea3 
…meshtimeout_api
@Automaat
feat(kuma-cp): update golden files
b84fdb2 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into feat/meshtimeout_api
aef141c
@Automaat
Merge branch 'master' into feat/meshtimeout_api
ff151b4
@Automaat
Merge branch 'master' into feat/meshtimeout_api
0618400
@Automaat
Merge branch 'master' into feat/meshtimeout_api
dff0a9a
@Automaat
Merge branch 'master' into feat/meshtimeout_api
94a9b98
@Automaat
Merge branch 'master' into feat/meshtimeout_api
4cf79ac
slonka
slonka approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me when you address all of the comments from other reviewers

pkg/core/validators/common_validators.go Outdated Show resolved Hide resolved
@Automaat
Merge branch 'master' into feat/meshtimeout_api
62fb87d
@Automaat
feat(kuma-cp): change Duration type to k8s one
cc4dcd4 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): fix check
9528385 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat merged commit 531d380 into kumahq:master Nov 21, 2022
@Automaat Automaat deleted the feat/meshtimeout_api branch November 21, 2022 15:58
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobkovilya lobkovilya lobkovilya left review comments

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont left review comments

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MeshTimeout
5 participants
@Automaat @lahabana @michaelbeaumont @slonka @lobkovilya