Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(diagnostics): add possibility to run diagnostics on TLS #5344

Merged
merged 6 commits into from
Nov 21, 2022
Merged

feat(diagnostics): add possibility to run diagnostics on TLS #5344

merged 6 commits into from
Nov 21, 2022

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 18, 2022 •
edited by lahabana
Loading

Add configuration to be able to setup diagnostics port with TLS.
The configuration is standard to other services (including autoconfigure with KUMA_GENERAL_TLS) but TLS
is disabled by default to ensure backward compatibility to enable you'll need to set: KUMA_DIAGNOSTICS_TLS_ENABLED=true

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Changelog: feat(kuma-cp): add possibility to run diagnostics on TLS

mmorel-35
mmorel-35 commented Nov 18, 2022
View reviewed changes
pkg/diagnostics/server.go Outdated Show resolved Hide resolved
@mmorel-35 mmorel-35 marked this pull request as ready for review November 18, 2022 12:53
@mmorel-35 mmorel-35 requested a review from a team as a code owner November 18, 2022 12:53
lahabana
lahabana reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions thx! A few minor comments but I've tried and everything works

pkg/config/app/kuma-cp/kuma-cp.defaults.yaml Outdated Show resolved Hide resolved
pkg/diagnostics/server.go Outdated Show resolved Hide resolved
pkg/diagnostics/server.go Outdated Show resolved Hide resolved
@mmorel-35
feat(diagnostics): add possibility to run diagnostics on TLS
0fa1e61 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
disabled by default
0c52011 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
fix comments
ae2df48 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
apply make fmt
1fdef0c 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Update kuma-cp.defaults.yaml
e003473 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Simplify HTTP Server start
4006e60 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
lahabana
lahabana approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for this addition!

@lahabana lahabana merged commit 450f835 into kumahq:master Nov 21, 2022
@mmorel-35 mmorel-35 deleted the diagnostic-tls branch November 21, 2022 15:14
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @lahabana