Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): change way of setting if resource is read only #5345

Merged
merged 6 commits into from
Nov 21, 2022

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Nov 18, 2022

Changed how we check if a resource should be read-only. Previously we were allowing only Dataplane resources to be edited on the zone, now we are checking if the resource is synchronized and in which direction.

If we are on Global:

  • and resource is synchronized from Global
  • or resource is not synchronized
  • or resource is synchronized from Global and from Zone
    we allow you to edit it from global.

If we are on Zone:

  • and resource is synchronized from Zone
  • or resource is not synchronized
  • or resource is synchronized from Global and from Zone
    we allow you to edit it from Zone.
  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

…ld be readonly

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi requested a review from a team as a code owner November 18, 2022 13:25
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
pkg/api-server/server.go Outdated Show resolved Hide resolved
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi merged commit dd2a67d into kumahq:master Nov 21, 2022
@lukidzi
Copy link
Contributor Author

lukidzi commented Nov 21, 2022

@Mergifyio backport release-2.0

mergify bot pushed a commit that referenced this pull request Nov 21, 2022
Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
(cherry picked from commit dd2a67d)

# Conflicts:
#	pkg/api-server/server.go
@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2022

backport release-2.0

✅ Backports have been created

lukidzi pushed a commit that referenced this pull request Nov 21, 2022
…#5345) (#5348)

Signed-off-by: Łukasz Dziedziak <lukidzi@gmail.com>
@lahabana lahabana mentioned this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants