Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): implement MeshTimeout policy #5364

Merged
merged 28 commits into from
Dec 13, 2022
Merged

feat(kuma-cp): implement MeshTimeout policy #5364

merged 28 commits into from
Dec 13, 2022

Conversation

Automaat
Copy link
Contributor

@Automaat Automaat commented Nov 23, 2022 •
edited by lahabana
Loading

Fixes: #5267
Signed-off-by: Marcin Skalski marcin.skalski@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshTimeout policy

@Automaat
feat(kuma-cp): implement MeshTimeout policy
ebcb5b9 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested a review from a team as a code owner November 23, 2022 13:07
jakubdyszkiewicz
jakubdyszkiewicz reviewed Dec 2, 2022
View reviewed changes
test/e2e_env/universal/timeout/meshtimeout.go Outdated Show resolved Hide resolved
test/e2e_env/universal/timeout/meshtimeout.go Outdated Show resolved Hide resolved
test/e2e_env/universal/timeout/meshtimeout.go Show resolved Hide resolved
test/e2e_env/universal/timeout/meshtimeout.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/xds/configurer.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/xds/configurer.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/xds/configurer.go Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin_test.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
@Automaat
feat(kuma-cp): timeout implementation for gateways
82d67f4 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into feat/mesh_timeout
ea2b863
@Automaat
feat(kuma-cp): code review
be4772c 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into feat/mesh_timeout
8d344b4
@Automaat
feat(kuma-cp): fixed check
e4f10eb 
Fixes: kumahq#5267
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@lahabana
Copy link
Contributor

lahabana commented Dec 5, 2022

What's missing to push this PR through?

@Automaat Automaat requested review from a team, michaelbeaumont and slonka and removed request for a team December 8, 2022 08:23
@lukidzi lukidzi mentioned this pull request Dec 8, 2022
Merged
12 tasks
slonka
slonka reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, if I got it right when it comes to tcp / http tests would be good to rename the golden files as well.

pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin_test.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin_test.go Outdated Show resolved Hide resolved
pkg/xds/envoy/routes/route_configuration_builder.go Outdated Show resolved Hide resolved
pkg/xds/envoy/routes/route_configuration_builder.go Outdated Show resolved Hide resolved
test/e2e_env/kubernetes/meshtimeout/api.go Outdated Show resolved Hide resolved
test/e2e_env/universal/timeout/meshtimeout.go Outdated Show resolved Hide resolved
test/e2e_env/universal/timeout/meshtimeout.go Show resolved Hide resolved
@Automaat
feat(kuma-cp): code review
d16721b 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into feat/mesh_timeout
f030595
@Automaat
feat(kuma-cp): fix naming
a6abbdc 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): changed e2e test namespace
4b1b40c 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into feat/mesh_timeout
79c1823
@Automaat
feat(kuma-cp): fix check
47e8a11 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into feat/mesh_timeout
93265c2
@Automaat
feat(kuma-cp): fix e2e tests
e64f875 
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
slonka
slonka approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! 🎉

pkg/plugins/policies/meshtimeout/plugin/v1alpha1/plugin_test.go Outdated Show resolved Hide resolved
pkg/plugins/policies/meshtimeout/plugin/xds/configurer.go Show resolved Hide resolved
@Automaat Automaat enabled auto-merge (squash) December 13, 2022 11:26
@Automaat Automaat merged commit 8ffb14b into kumahq:master Dec 13, 2022
@Automaat Automaat deleted the feat/mesh_timeout branch December 13, 2022 11:54
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi left review comments

@bartsmykla bartsmykla bartsmykla left review comments

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@slonka slonka slonka approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement MeshTimeout
7 participants
@Automaat @lahabana @michaelbeaumont @slonka @jakubdyszkiewicz @bartsmykla @lukidzi