Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp): remove value of secret when logging Secret Resources #5384

Merged
merged 9 commits into from
Dec 1, 2022
Merged

feat(kuma-cp): remove value of secret when logging Secret Resources #5384

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9c604d3
feat(kuma-cp): remove value of secret when logging Secret Resources
Automaat Nov 30, 2022
613c1ff
Merge branch 'master' into fix/loggin_private_keys_on_debug
Automaat Nov 30, 2022
8bc9d94
Merge branch 'master' into fix/loggin_private_keys_on_debug
lahabana Nov 30, 2022
a9d426e
feat(kuma-cp): add masking for external service and mesh
Automaat Dec 1, 2022
91f1665
feat(kuma-cp): added masking for single resource
Automaat Dec 1, 2022
c8acd7f
feat(kuma-cp): linting
Automaat Dec 1, 2022
f31ced0
feat(kuma-cp): code review
Automaat Dec 1, 2022
56075ae
feat(kuma-cp): fixed typo
Automaat Dec 1, 2022
6e32da6
Merge branch 'master' into fix/loggin_private_keys_on_debug
Automaat Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/system/v1alpha1/secret_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package v1alpha1

func (s *Secret) MarshalLog() interface{} {
return "***"
}
32 changes: 32 additions & 0 deletions pkg/core/resources/apis/system/secret_resource_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package system

import (
"github.com/kumahq/kuma/pkg/core/resources/model"
)

type secretResource struct {
Meta model.ResourceMeta
Spec string
}

func (l *SecretResourceList) MarshalLog() interface{} {
list := make([]secretResource, len(l.Items))
for _, res := range l.Items {
list = append(list, secretResource{
Meta: res.GetMeta(),
Spec: "***",
})
}
return list
}

func (l *GlobalSecretResourceList) MarshalLog() interface{} {
list := make([]secretResource, len(l.Items))
for _, res := range l.Items {
list = append(list, secretResource{
Meta: res.GetMeta(),
Spec: "***",
})
}
return list
}