Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kuma-cp): remove value of secret when logging Secret Resources #5384

Merged
merged 9 commits into from
Dec 1, 2022
Merged

feat(kuma-cp): remove value of secret when logging Secret Resources #5384

merged 9 commits into from
Dec 1, 2022

Conversation

Automaat
Copy link
Contributor

Fixes: #2058

Signed-off-by: Marcin Skalski marcin.skalski@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@Automaat
feat(kuma-cp): remove value of secret when logging Secret Resources
9c604d3 
Fixes: kumahq#2058
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat Automaat requested a review from a team as a code owner November 30, 2022 12:04
michaelbeaumont
michaelbeaumont approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lahabana
Copy link
Contributor

LGTM I guess you've checked this manually?

lahabana and others added 3 commits November 30, 2022 21:39
@lahabana
Merge branch 'master' into fix/loggin_private_keys_on_debug
8bc9d94
@Automaat
feat(kuma-cp): add masking for external service and mesh
a9d426e 
Fixes: kumahq#2058
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): added masking for single resource
91f1665 
Fixes: kumahq#2058
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): linting
c8acd7f 
Fixes: kumahq#2058
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): code review
f31ced0 
Fixes: kumahq#2058
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
feat(kuma-cp): fixed typo
56075ae 
Fixes: kumahq#2058
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
@Automaat
Merge branch 'master' into fix/loggin_private_keys_on_debug
6e32da6
@lahabana
Copy link
Contributor

lahabana commented Dec 1, 2022 •
edited
Loading

@Mergifyio backport release-2.0 release-1.8 release-1.7 release-1.6 release-1.5

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022 •
edited
Loading

backport release-2.0 release-1.8 release-1.7 release-1.6 release-1.5

✅ Backports have been created

@kumahq kumahq deleted a comment from mergify bot Dec 1, 2022
@Automaat Automaat merged commit cddddc9 into kumahq:master Dec 1, 2022
@Automaat Automaat deleted the fix/loggin_private_keys_on_debug branch December 1, 2022 12:59
@mergify mergify bot mentioned this pull request Dec 1, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 1, 2022
@Automaat @mergify
feat(kuma-cp): remove value of secret when logging Secret Resources (#…
95c4552 
…5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)
mergify bot pushed a commit that referenced this pull request Dec 1, 2022
@Automaat @mergify
feat(kuma-cp): remove value of secret when logging Secret Resources (#…
abeb7a7 
…5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)
This was referenced Dec 1, 2022
Merged
Merged
mergify bot pushed a commit that referenced this pull request Dec 1, 2022
@Automaat @mergify
feat(kuma-cp): remove value of secret when logging Secret Resources (#…
68e0cfc 
…5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)
@mergify mergify bot mentioned this pull request Dec 1, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 1, 2022
@Automaat @mergify
feat(kuma-cp): remove value of secret when logging Secret Resources (#…
85cbb02 
…5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)
mergify bot pushed a commit that referenced this pull request Dec 1, 2022
@Automaat @mergify
feat(kuma-cp): remove value of secret when logging Secret Resources (#…
066637a 
…5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)
@mergify mergify bot mentioned this pull request Dec 1, 2022
Merged
mergify bot added a commit that referenced this pull request Dec 1, 2022
@mergify @Automaat
feat(kuma-cp): remove value of secret when logging Secret Resources (…
82be943 
…backport #5384) (#5392)

feat(kuma-cp): remove value of secret when logging Secret Resources (#5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)

Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
mergify bot added a commit that referenced this pull request Dec 2, 2022
@mergify @Automaat
feat(kuma-cp): remove value of secret when logging Secret Resources (…
a976e15 
…backport #5384) (#5395)

feat(kuma-cp): remove value of secret when logging Secret Resources (#5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)

Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
mergify bot added a commit that referenced this pull request Dec 2, 2022
@mergify @Automaat
feat(kuma-cp): remove value of secret when logging Secret Resources (…
fafe523 
…backport #5384) (#5394)

feat(kuma-cp): remove value of secret when logging Secret Resources (#5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)

Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
Automaat added a commit that referenced this pull request Dec 2, 2022
@Automaat
feat(kuma-cp): remove value of secret when logging Secret Resources (#…
07c629a 
…5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
mergify bot added a commit that referenced this pull request Dec 2, 2022
@mergify @Automaat
feat(kuma-cp): remove value of secret when logging Secret Resources (…
77796d8 
…backport #5384) (#5393)

feat(kuma-cp): remove value of secret when logging Secret Resources (#5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)

Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
mergify bot added a commit that referenced this pull request Dec 2, 2022
@mergify @Automaat
feat(kuma-cp): remove value of secret when logging Secret Resources (…
39c0dc2 
…backport #5384) (#5396)

* feat(kuma-cp): remove value of secret when logging Secret Resources (#5384)

* feat(kuma-cp): remove value of secret when logging Secret Resources

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
(cherry picked from commit cddddc9)
Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>

* fix(test): fixed tests

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>

Signed-off-by: Marcin Skalski <marcin.skalski@konghq.com>
Co-authored-by: Marcin Skalski <marcin.skalski@konghq.com>
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukidzi lukidzi lukidzi approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: add codecov Github App
4 participants
@Automaat @lahabana @michaelbeaumont @lukidzi