fix(xds): don't read metadata in ProxyBuilders #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using a `DataplaneMetadataTracker` in all proxy builders. This was causing issues as the proxy may disconnect while reconciliation is in progress. We now set the proxy metadata in the DataplaneWatchdog so that it's read once only and nil checked. We therefore protect ourselves against this race Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
@Mergifyio backport release-2.0 |
✅ Backports have been created
|
jakubdyszkiewicz
approved these changes
Dec 2, 2022
mergify bot
pushed a commit
that referenced
this pull request
Dec 2, 2022
We were using a `DataplaneMetadataTracker` in all proxy builders. This was causing issues as the proxy may disconnect while reconciliation is in progress. We now set the proxy metadata in the DataplaneWatchdog so that it's read once only and nil checked. We therefore protect ourselves against this race Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 39ba902) # Conflicts: # pkg/api-server/inspect_endpoints.go # pkg/xds/sync/components.go # pkg/xds/sync/egress_proxy_builder.go # pkg/xds/sync/ingress_proxy_builder.go
lahabana
pushed a commit
that referenced
this pull request
Dec 2, 2022
We were using a `DataplaneMetadataTracker` in all proxy builders. This was causing issues as the proxy may disconnect while reconciliation is in progress. We now set the proxy metadata in the DataplaneWatchdog so that it's read once only and nil checked. We therefore protect ourselves against this race Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 39ba902) Signed-off-by: Charly Molter <charly.molter@konghq.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a
DataplaneMetadataTrackerin all proxy builders. This was causing issues as the proxy may disconnect while reconciliation is in progress.We now set the proxy metadata in the DataplaneWatchdog so that it's read once only and nil checked. We therefore protect ourselves against this race
Signed-off-by: Charly Molter charly.molter@konghq.com
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? --> Changelog:entry here or add aci/label to run fewer/more tests?