Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(universal): don't set sslsni option if not disabled #5419

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix(universal): don't set sslsni option if not disabled #5419

merged 2 commits into from
Dec 5, 2022

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Dec 5, 2022 •
edited
Loading

This option is apparently relatively new, postgres 14, so we should skip including it unless it's explicitly disabled and let libpg handle the default.

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests -- none
  • Manual Kubernetes Tests -- none
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@michaelbeaumont
fix(universal): don't set sslsni option if not disabled
33dd170 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner December 5, 2022 08:22
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) December 5, 2022 08:24
@michaelbeaumont
refactor: more robust connection string creation
f7367e6 
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont enabled auto-merge (squash) December 5, 2022 09:02
@michaelbeaumont michaelbeaumont merged commit 2791963 into kumahq:release-2.0 Dec 5, 2022
@michaelbeaumont michaelbeaumont deleted the fix/postgres_skip_string branch December 5, 2022 09:35
@michaelbeaumont
Copy link
Contributor Author

@Mergifyio backport master

mergify bot pushed a commit that referenced this pull request Dec 5, 2022
@michaelbeaumont @mergify
fix(universal): don't set sslsni option if not disabled (#5419)
a7187be 
* fix(universal): don't set sslsni option if not disabled
* refactor: more robust connection string creation

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 2791963)
@mergify mergify bot mentioned this pull request Dec 5, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Dec 5, 2022

backport master

✅ Backports have been created

michaelbeaumont added a commit that referenced this pull request Dec 5, 2022
@mergify @michaelbeaumont
fix(universal): don't set sslsni option if not disabled (backport #5419…
5673335 
…) (#5439)

fix(universal): don't set `sslsni` option if not disabled (#5419)

* fix(universal): don't set sslsni option if not disabled
* refactor: more robust connection string creation

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 2791963)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
@lahabana lahabana mentioned this pull request Dec 13, 2022
Closed
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbeaumont @lahabana