Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp): retrieve name from owner not parsing pod name for Deployments/CronJob #5569

Merged
merged 8 commits into from
Jan 9, 2023
Merged

fix(kuma-cp): retrieve name from owner not parsing pod name for Deployments/CronJob #5569

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de6dc7a
fix(kuma-cp): change the way of retreiving the name for Deployments/C…
lukidzi Jan 3, 2023
01bb851
fix(kuma-cp): fix permissions
lukidzi Jan 3, 2023
58776ea
fix(kuma-cp): update files
lukidzi Jan 3, 2023
04c16b0
fix(kuma-cp): introduce breaking change, fix test
lukidzi Jan 4, 2023
2de1a44
fix(kuma-cp): run check
lukidzi Jan 4, 2023
0b41fc2
fix(kuma-cp): applied changes to upgrade note
lukidzi Jan 5, 2023
6ad56cd
fix(kuma-cp): change function and updated upgrade file
lukidzi Jan 5, 2023
1bfd29c
Merge branch 'master' into fix/serviceless
lukidzi Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,28 @@ does not have any particular instructions.

## Upcoming release

### http api
### **List of breaking changes**
lukidzi marked this conversation as resolved.
Show resolved Hide resolved

#### **Naming of Serviceless has changed**
lukidzi marked this conversation as resolved.
Show resolved Hide resolved

Currently, serviceless pods' name is generated based on the `Pod` name. `Kuma-cp` takes the pod's name and removes 2 last elements after splitting by `-`. This behavior is correct when `Pod` is managed by `Deployment` or `CronJob` but not for other types. We've introduced the change that takes the name from the parent resource which breaks current behavior.
lukidzi marked this conversation as resolved.
Show resolved Hide resolved
Before upgrade:
1. Identify all serviceless pods that are not managed by `Deployment` or `CronJob`.
2. Create policies that were created for services but with a new name. The name is an owner name, in case there is no owner `Kuma` uses `Pod` name.
3. Upgrade `Kuma`.
lukidzi marked this conversation as resolved.
Show resolved Hide resolved
lukidzi marked this conversation as resolved.
Show resolved Hide resolved

### Other changes
lukidzi marked this conversation as resolved.
Show resolved Hide resolved

#### http api
lukidzi marked this conversation as resolved.
Show resolved Hide resolved

We've removed the endpoint `POST /tokens` which has been moved by `POST /tokens/dataplane` (same request and response) some time ago.
Make sure you are using a recent `kumactl` or that you use the right path if using the api directly to upgrade with no issues.

### Kubernetes
#### Kubernetes
lukidzi marked this conversation as resolved.
Show resolved Hide resolved

The sidecar container is always injected first (since [#5436](https://github.com/kumahq/kuma/pull/5436)). This should only impact you when modifying the sidecar container with a container-patch. If you do so, upgrade Kuma and then change your container patch to modify the right container.

### Kumactl
#### Kumactl
lukidzi marked this conversation as resolved.
Show resolved Hide resolved

`--valid-for` must be set for all token types, before it was defaulting to 10 years.

Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.cni-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -119,6 +120,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.cni-experimental-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -119,6 +120,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3745,6 +3745,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -3753,6 +3754,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present-not-enabled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3745,6 +3745,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -3753,6 +3754,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3878,6 +3878,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -3886,6 +3887,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.global.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -64,6 +65,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.override-env-vars.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -64,6 +65,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.overrides.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -65,6 +66,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.registry.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -64,6 +65,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions ...l/cmd/install/testdata/install-control-plane.tproxy-ebpf-experimental-enabled.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -64,6 +65,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-egress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -74,6 +75,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3765,6 +3765,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -3773,6 +3774,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -64,6 +65,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-ingress.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -74,6 +75,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-control-plane.zone.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -64,6 +65,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
9 changes: 9 additions & 0 deletions app/kumactl/cmd/install/testdata/install-cp-helm/empty.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ rules:
- "apps"
resources:
- deployments
- replicasets
verbs:
- create
- delete
Expand All @@ -64,6 +65,14 @@ rules:
- patch
- update
- watch
- apiGroups:
- "batch"
resources:
- jobs
verbs:
- get
- list
- watch
- apiGroups:
- gateway.networking.k8s.io
resources:
Expand Down
Loading