Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust MeshHealthCheck to follow the memo #5713

Merged
merged 5 commits into from
Jan 17, 2023
Merged

fix: adjust MeshHealthCheck to follow the memo #5713

merged 5 commits into from
Jan 17, 2023

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Jan 16, 2023 •
edited by lahabana
Loading

  • Change MeshHealthCheck definition
  • Add unit tests

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(policy): implement MeshHealthCheck policy

@lobkovilya
fix: adjust MeshHealthCheck to follow the memo
98adb29 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya
fix: make check
58595b1 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya marked this pull request as ready for review January 16, 2023 14:52
@lobkovilya lobkovilya requested review from a team, slonka and jakubdyszkiewicz and removed request for a team January 16, 2023 14:52
@lobkovilya lobkovilya self-assigned this Jan 16, 2023
@michaelbeaumont michaelbeaumont linked an issue Jan 16, 2023 that may be closed by this pull request
MeshHealthCheck HTTP path must defined even when disabling HTTP #5714
Closed
@lobkovilya
Merge branch 'master' into fix/adjust-mhc
26dbfcf 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/meshhealthcheck/plugin/xds/configurer.go
@lobkovilya
Merge branch 'master' into fix/adjust-mhc
1e6e291 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/policies/meshhealthcheck/plugin/xds/configurer.go
@lobkovilya
make 'append' true by default
18075e0 
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya merged commit 4f3da47 into kumahq:master Jan 17, 2023
@lobkovilya lobkovilya deleted the fix/adjust-mhc branch January 17, 2023 17:15
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lahabana lahabana lahabana approved these changes

@slonka slonka Awaiting requested review from slonka

Assignees

@lobkovilya lobkovilya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MeshHealthCheck HTTP path must defined even when disabling HTTP
3 participants
@lobkovilya @lahabana @jakubdyszkiewicz