Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust MeshHealthCheck to follow the memo #5713

Merged
merged 5 commits into from
Jan 17, 2023
Merged

fix: adjust MeshHealthCheck to follow the memo #5713

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
98adb29
fix: adjust MeshHealthCheck to follow the memo
lobkovilya Jan 16, 2023
58595b1
fix: make check
lobkovilya Jan 16, 2023
26dbfcf
Merge branch 'master' into fix/adjust-mhc
lobkovilya Jan 17, 2023
1e6e291
Merge branch 'master' into fix/adjust-mhc
lobkovilya Jan 17, 2023
18075e0
make 'append' true by default
lobkovilya Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions app/kumactl/cmd/install/testdata/install-control-plane.defaults.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@ spec:
format: int32
type: integer
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
considering a host healthy.
format: int32
Expand All @@ -674,6 +675,7 @@ spec:
type: integer
type: array
path:
default: /
description: The HTTP path which will be requested during
the health check (ie. /health)
type: string
Expand All @@ -686,17 +688,15 @@ spec:
description: If true (default) the header values
should be appended to already present ones
type: boolean
header:
description: Key/Value representation of the HTTP
header
properties:
key:
description: Header name
type: string
value:
description: Header value
type: string
type: object
key:
description: Header name
type: string
value:
description: Header value
type: string
required:
- key
- value
type: object
type: array
type: object
Expand All @@ -706,6 +706,7 @@ spec:
This only applies to the first health check.
type: string
interval:
default: 1m
description: Interval between consecutive health checks.
type: string
intervalJitter:
Expand Down Expand Up @@ -762,9 +763,11 @@ spec:
type: string
type: object
timeout:
default: 15s
description: Maximum time to wait for a health check response.
type: string
unhealthyThreshold:
default: 5
description: Number of consecutive unhealthy checks before
considering a host unhealthy.
format: int32
Expand Down
25 changes: 14 additions & 11 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present-not-enabled.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@ spec:
format: int32
type: integer
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
considering a host healthy.
format: int32
Expand All @@ -674,6 +675,7 @@ spec:
type: integer
type: array
path:
default: /
description: The HTTP path which will be requested during
the health check (ie. /health)
type: string
Expand All @@ -686,17 +688,15 @@ spec:
description: If true (default) the header values
should be appended to already present ones
type: boolean
header:
description: Key/Value representation of the HTTP
header
properties:
key:
description: Header name
type: string
value:
description: Header value
type: string
type: object
key:
description: Header name
type: string
value:
description: Header value
type: string
required:
- key
- value
type: object
type: array
type: object
Expand All @@ -706,6 +706,7 @@ spec:
This only applies to the first health check.
type: string
interval:
default: 1m
description: Interval between consecutive health checks.
type: string
intervalJitter:
Expand Down Expand Up @@ -762,9 +763,11 @@ spec:
type: string
type: object
timeout:
default: 15s
description: Maximum time to wait for a health check response.
type: string
unhealthyThreshold:
default: 5
description: Number of consecutive unhealthy checks before
considering a host unhealthy.
format: int32
Expand Down
25 changes: 14 additions & 11 deletions app/kumactl/cmd/install/testdata/install-control-plane.gateway-api-present.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,7 @@ spec:
format: int32
type: integer
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
considering a host healthy.
format: int32
Expand All @@ -806,6 +807,7 @@ spec:
type: integer
type: array
path:
default: /
description: The HTTP path which will be requested during
the health check (ie. /health)
type: string
Expand All @@ -818,17 +820,15 @@ spec:
description: If true (default) the header values
should be appended to already present ones
type: boolean
header:
description: Key/Value representation of the HTTP
header
properties:
key:
description: Header name
type: string
value:
description: Header value
type: string
type: object
key:
description: Header name
type: string
value:
description: Header value
type: string
required:
- key
- value
type: object
type: array
type: object
Expand All @@ -838,6 +838,7 @@ spec:
This only applies to the first health check.
type: string
interval:
default: 1m
description: Interval between consecutive health checks.
type: string
intervalJitter:
Expand Down Expand Up @@ -894,9 +895,11 @@ spec:
type: string
type: object
timeout:
default: 15s
description: Maximum time to wait for a health check response.
type: string
unhealthyThreshold:
default: 5
description: Number of consecutive unhealthy checks before
considering a host unhealthy.
format: int32
Expand Down
25 changes: 14 additions & 11 deletions app/kumactl/cmd/install/testdata/install-control-plane.with-helm-set.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,7 @@ spec:
format: int32
type: integer
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
considering a host healthy.
format: int32
Expand All @@ -694,6 +695,7 @@ spec:
type: integer
type: array
path:
default: /
description: The HTTP path which will be requested during
the health check (ie. /health)
type: string
Expand All @@ -706,17 +708,15 @@ spec:
description: If true (default) the header values
should be appended to already present ones
type: boolean
header:
description: Key/Value representation of the HTTP
header
properties:
key:
description: Header name
type: string
value:
description: Header value
type: string
type: object
key:
description: Header name
type: string
value:
description: Header value
type: string
required:
- key
- value
type: object
type: array
type: object
Expand All @@ -726,6 +726,7 @@ spec:
This only applies to the first health check.
type: string
interval:
default: 1m
description: Interval between consecutive health checks.
type: string
intervalJitter:
Expand Down Expand Up @@ -782,9 +783,11 @@ spec:
type: string
type: object
timeout:
default: 15s
description: Maximum time to wait for a health check response.
type: string
unhealthyThreshold:
default: 5
description: Number of consecutive unhealthy checks before
considering a host unhealthy.
format: int32
Expand Down
25 changes: 14 additions & 11 deletions app/kumactl/cmd/install/testdata/install-crds.all.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1825,6 +1825,7 @@ spec:
format: int32
type: integer
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
considering a host healthy.
format: int32
Expand All @@ -1845,6 +1846,7 @@ spec:
type: integer
type: array
path:
default: /
description: The HTTP path which will be requested during
the health check (ie. /health)
type: string
Expand All @@ -1857,17 +1859,15 @@ spec:
description: If true (default) the header values
should be appended to already present ones
type: boolean
header:
description: Key/Value representation of the HTTP
header
properties:
key:
description: Header name
type: string
value:
description: Header value
type: string
type: object
key:
description: Header name
type: string
value:
description: Header value
type: string
required:
- key
- value
type: object
type: array
type: object
Expand All @@ -1877,6 +1877,7 @@ spec:
This only applies to the first health check.
type: string
interval:
default: 1m
description: Interval between consecutive health checks.
type: string
intervalJitter:
Expand Down Expand Up @@ -1933,9 +1934,11 @@ spec:
type: string
type: object
timeout:
default: 15s
description: Maximum time to wait for a health check response.
type: string
unhealthyThreshold:
default: 5
description: Number of consecutive unhealthy checks before
considering a host unhealthy.
format: int32
Expand Down
25 changes: 14 additions & 11 deletions app/kumactl/cmd/install/testdata/install-crds.experimental-gatewayapi.golden.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,6 +1957,7 @@ spec:
format: int32
type: integer
healthyThreshold:
default: 1
description: Number of consecutive healthy checks before
considering a host healthy.
format: int32
Expand All @@ -1977,6 +1978,7 @@ spec:
type: integer
type: array
path:
default: /
description: The HTTP path which will be requested during
the health check (ie. /health)
type: string
Expand All @@ -1989,17 +1991,15 @@ spec:
description: If true (default) the header values
should be appended to already present ones
type: boolean
header:
description: Key/Value representation of the HTTP
header
properties:
key:
description: Header name
type: string
value:
description: Header value
type: string
type: object
key:
description: Header name
type: string
value:
description: Header value
type: string
required:
- key
- value
type: object
type: array
type: object
Expand All @@ -2009,6 +2009,7 @@ spec:
This only applies to the first health check.
type: string
interval:
default: 1m
description: Interval between consecutive health checks.
type: string
intervalJitter:
Expand Down Expand Up @@ -2065,9 +2066,11 @@ spec:
type: string
type: object
timeout:
default: 15s
description: Maximum time to wait for a health check response.
type: string
unhealthyThreshold:
default: 5
description: Number of consecutive unhealthy checks before
considering a host unhealthy.
format: int32
Expand Down
Loading