-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatewayapi): correctly handle invalid backendRefs #6428
fix(gatewayapi): correctly handle invalid backendRefs #6428
Conversation
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
deba808
to
6a2695b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I'm a little surprised such a value is accepted as a tag value.
Yeah, you're right. It's because we validate |
I'm going to merge this. We can potentially discuss validation later |
The idea here is to configure a reference to a cluster that doesn't exist and let Envoy return a 500 error.
A different option would be to mark a backend explicitly as missing endpoints, as opposed to a special tag value:
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --UPGRADE.md
? --> Changelog:
entry here or add aci/
label to run fewer/more tests?