-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MeshHTTPRoute): allow "kuma.io/unresolved-backend" service name for GAMMA compliance #9670
fix(MeshHTTPRoute): allow "kuma.io/unresolved-backend" service name for GAMMA compliance #9670
Conversation
…name Normally, service names cannot contain forward slashes ("/"). However, there are exceptions during resource conversion: * Gateway API to Kuma MeshHTTPRoute Conversion When converting an HTTPRoute from Gateway API to a MeshHTTPRoute (Kuma's resource definition), there might be situations where the targeted backend reference cannot be found. In such cases, Kuma sets the service name to "kuma.io/unresolved-backend". This name includes a forward slash, but it's allowed as an exception to handle unresolved references. Signed-off-by: Bart Smykla <bartek@smykla.com>
I think this value seems weird. Weakening validation seems pretty risky to me... what's @michaelbeaumont 's opinion? |
@lahabana that's how it currently work for What could be done is what @michaelbeaumont suggested here:
|
…ved-backend-service-name-in-gamma-httproute-conversion
…ved-backend-service-name-in-gamma-httproute-conversion
Yeah, the option as Bart pointed out would work. I wouldn't look at it as weakening validation per se, it's just to allow us to use a reserved string, same as we do for keys. Is there another way to prevent a collision with a real service? |
We can switch this behavior in following up PR. I would vote for merging this as currently when |
Normally, service names cannot contain forward slashes ("/"). However, there are exceptions during resource conversion:
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OSci/
labels to run additional/fewer testsUPGRADE.md
?