ci(tests): add container structure tests #6581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
force-pushed
the
ci/add-container-stucture-tests
branch
from
8135843 to
fc5b054
Compare
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
added
the
ci/run-full-matrix
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
…e-tests Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
changed the title
This was referenced Apr 24, 2023
…e-tests Signed-off-by: Bart Smykla <bartek@smykla.com>
lahabana
reviewed
Apr 24, 2023
|
I'm not sure. Having it separately is cleaner for me, and I think it's easier to potentially debug. Especially as |
Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
changed the title
bartsmykla
requested review from
a team,
Automaat,
lobkovilya and
lahabana
and removed request for
a team
Signed-off-by: Bart Smykla <bartek@smykla.com>
6 tasks
Signed-off-by: Bart Smykla <bartek@smykla.com>
Automaat
approved these changes
Apr 25, 2023
|
@Mergifyio backport release-2.2 release-2.1 release-2.0 release-1.8 release-1.7 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
* skip arm64 on kuma-commit by default * add entrypoints to structure tests Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit 42e4980)
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
* skip arm64 on kuma-commit by default * add entrypoints to structure tests Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit 42e4980) # Conflicts: # .circleci/config.yml # Makefile # mk/dependencies/deps.lock
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
* skip arm64 on kuma-commit by default * add entrypoints to structure tests Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit 42e4980) # Conflicts: # .circleci/config.yml # Makefile # mk/dependencies/deps.lock
This was referenced Apr 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
* skip arm64 on kuma-commit by default * add entrypoints to structure tests Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit 42e4980) # Conflicts: # .circleci/config.yml # Makefile # mk/dependencies/deps.lock # mk/dev.mk
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
* skip arm64 on kuma-commit by default * add entrypoints to structure tests Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit 42e4980) # Conflicts: # .circleci/config.yml # Makefile # mk/dependencies/deps.lock # mk/dev.mk
This was referenced Apr 25, 2023
bartsmykla
pushed a commit
that referenced
this pull request
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial version of this feature as the configurations for structure tests can be improved, to for example test if versions of the binaries are expected (this involve introducing dynamic [containing exact versions] configuration files)
I would prefer to make testing entrypoints declarative, so instead of explicitly checking if its value is equal
X, to check if i.e. runningdocker run kumahq/kuma-cp:2.2.0 versionworks. We can't usecontainer-structure-teststo achieve it, as it overrides entrypoints, so I decided to accept this compromise. Maybe in the future if there will be need, we can just run commands likedocker run kumahq/kuma-cp:2.2.0 versionin tests directly.syscall.Mkfifohave equivalent implementation on the other OS --UPGRADE.md? -- you don't> Changelog:entry here or add aci/label to run fewer/more tests?