fix(docker/kumactl): add entrypoint to kumactl img #6593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without specifying entrypoint inside the Dockerfile, it was impossible to use the image without having to do it explicitly during the container start It was impossible to do: ```sh docker run kumahq/kuma:2.2.0 kumactl version ``` and you had to explicitly specify entrypoint ```sh docker run --entrypoint /usr/bin/kumactl kumahq/kuma:2.2.0 version ``` Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
requested review from
a team,
slonka and
lukidzi
and removed request for
a team
|
@Mergifyio backport release-2.2 release-2.1 |
✅ Backports have been created
|
slonka
reviewed
Apr 24, 2023
slonka
approved these changes
Apr 24, 2023
|
Also I think this is more |
bartsmykla
changed the title
Agree. Adjusted the PR's name. |
michaelbeaumont
approved these changes
Apr 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
Without specifying entrypoint inside the Dockerfile, it was impossible to use the image without having to do it explicitly during the container start It was impossible to do: ```sh docker run kumahq/kuma:2.2.0 kumactl version ``` and you had to explicitly specify entrypoint ```sh docker run --entrypoint /usr/bin/kumactl kumahq/kuma:2.2.0 version ``` Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit fe153f0)
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
Without specifying entrypoint inside the Dockerfile, it was impossible to use the image without having to do it explicitly during the container start It was impossible to do: ```sh docker run kumahq/kuma:2.2.0 kumactl version ``` and you had to explicitly specify entrypoint ```sh docker run --entrypoint /usr/bin/kumactl kumahq/kuma:2.2.0 version ``` Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit fe153f0)
6 tasks
mergify bot
added a commit
that referenced
this pull request
Apr 24, 2023
…6594) ci(docker/kumactl): add entrypoint to kumactl img (#6593) Without specifying entrypoint inside the Dockerfile, it was impossible to use the image without having to do it explicitly during the container start It was impossible to do: ```sh docker run kumahq/kuma:2.2.0 kumactl version ``` and you had to explicitly specify entrypoint ```sh docker run --entrypoint /usr/bin/kumactl kumahq/kuma:2.2.0 version ``` Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit fe153f0) Co-authored-by: Bart Smykla <bartek@smykla.com>
mergify bot
added a commit
that referenced
this pull request
Apr 24, 2023
…6595) ci(docker/kumactl): add entrypoint to kumactl img (#6593) Without specifying entrypoint inside the Dockerfile, it was impossible to use the image without having to do it explicitly during the container start It was impossible to do: ```sh docker run kumahq/kuma:2.2.0 kumactl version ``` and you had to explicitly specify entrypoint ```sh docker run --entrypoint /usr/bin/kumactl kumahq/kuma:2.2.0 version ``` Signed-off-by: Bart Smykla <bartek@smykla.com> (cherry picked from commit fe153f0) Co-authored-by: Bart Smykla <bartek@smykla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without specifying entrypoint inside the Dockerfile, it was impossible to use the image without having to do it explicitly during the container start
It was impossible to do:
docker run kumahq/kumactl:2.2.0 kumactl version # /busybox/sh: can't open 'kumactl': No such file or directoryand you had to explicitly specify entrypoint
before:
Closes: #6566
Checklist prior to review
syscall.Mkfifohave equivalent implementation on the other OS -- it won'tUPGRADE.md? -- you don't> Changelog:entry here or add aci/label to run fewer/more tests?