Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policy): add MeshTCPRoute api with validation #6806

Merged
merged 9 commits into from
May 23, 2023

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented May 22, 2023

Add MeshTCPRoute api with validation

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS
    • it won't
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
  • Do you need to update UPGRADE.md?
    • it's a new policy, so there is no need
  • Does it need to be backported according to the backporting policy?
    • it's a new policy, so there is no need
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?
    • nope

Changelog: feat(policy): add MeshTCPRoute

Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla changed the title feat(policy): add MeshTCPRoute api with validators feat(policy): add MeshTCPRoute api with validation May 22, 2023
@bartsmykla bartsmykla marked this pull request as ready for review May 22, 2023 09:01
@bartsmykla bartsmykla requested review from a team, michaelbeaumont and jakubdyszkiewicz and removed request for a team May 22, 2023 09:01
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla enabled auto-merge (squash) May 23, 2023 05:54
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartsmykla bartsmykla merged commit dd2abf0 into kumahq:master May 23, 2023
@bartsmykla bartsmykla deleted the feat/meshtcproute-api branch May 24, 2023 04:46
@bartsmykla bartsmykla mentioned this pull request May 25, 2023
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants