Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade go version to 1.20.4 #6828

Merged
merged 2 commits into from
May 24, 2023
Merged

chore(deps): upgrade go version to 1.20.4 #6828

merged 2 commits into from
May 24, 2023

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented May 23, 2023 •
edited by lobkovilya
Loading

Also fix bad merge of #6806

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: chore(deps): bump golang from 1.20.4 to 1.20.5

lukidzi added 2 commits May 23, 2023 20:15
@lukidzi
chore(deps): upgrade go version to 1.20.4
6c06ed0 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi
chore(deps): regenerate file
f6b0556 
Signed-off-by: Lukasz Dziedziak <lukidzi@gmail.com>
@lukidzi lukidzi marked this pull request as ready for review May 23, 2023 19:24
@lukidzi lukidzi requested review from a team, michaelbeaumont and lobkovilya and removed request for a team May 23, 2023 19:24
@bartsmykla bartsmykla merged commit 5428801 into kumahq:master May 24, 2023
@lahabana
Copy link
Contributor

@lukidzi @bartsmykla should this be backported too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukidzi @lahabana @bartsmykla