fix(charts): fix policy-reporter-ui backend name #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>
Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>
|
@m-yosefpor you can ignore the lint error. I can update the Chart version in preperation of the release |
|
I released your fix with v1.12.3 of the Helm Chart. Thank you for your support |
Wow thanks for your prompt action. Actually I just noticed that I have not pushed my latest changes and all my tests were based on an uncommited change and git status was not clean🤦. Please accept my apologies. I'll create another PR to fix this. |
|
merged, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kyverno/policy-reporter-kyverno-plugin#7
If you deployed the helm chart with another release name, instead of policy-reporter, policy-reporter svc name differs from ui.backend which leads to policies not be available in UI because. I think the charts shouldn't have such dependency, and it should be possible to have different chart release name than only
policy-reportername.