Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): fix to PR#85 #87

Merged
merged 4 commits into from
Oct 19, 2021
Merged

fix(charts): fix to PR#85 #87

merged 4 commits into from
Oct 19, 2021

Conversation

m-yosefpor
Copy link
Contributor

@m-yosefpor m-yosefpor commented Oct 18, 2021

Fixes #85

Tests:

changes to values.yaml before test:

ui:
  enabled: true

kyvernoPlugin:
  enabled: true

global:
  plugins:
    keyverno: true

All service name and -backend flag targets must be the same, when:

ReleaseName = policy-repoter

$ helm install --dry-run --debug policy-reporter policy-reporter | grep "\-backend"
            - -backend=http://policy-reporter:8080
            
$ helm template policy-reporter  policy-reporter -s templates/service.yaml | yq ".metadata.name" 
"policy-reporter"

ReleaseName = policy-reporter-ui Chart.Name = policy-repoter-ui

$ helm install --dry-run --debug policy-reporter-ui policy-reporter | grep "\-backend"
            - -backend=http://policy-reporter-ui:8080

$ helm template policy-reporter-ui  policy-reporter -s templates/service.yaml | yq ".metadata.name"
"policy-reporter-ui"

ReleaseName = contains policy-reporter keyword with suffix

$ helm install --dry-run --debug policy-reporter-mysuffix policy-reporter | grep "\-backend"
            - -backend=http://policy-reporter-mysuffix:8080
$ helm template policy-reporter-mysuffix  policy-reporter -s templates/service.yaml | yq ".metadata.name"
"policy-reporter-mysuffix"

ReleaseName = contains policy-reporter keyword with prefix

$ helm install --dry-run --debug myprefix-policy-reporter policy-reporter | grep "\-backend"
            - -backend=http://myprefix-policy-reporter:8080
$ helm template myprefix-policy-reporter  policy-reporter -s templates/service.yaml | yq ".metadata.name"
"myprefix-policy-reporter"

ReleaseName = contains policy-reporter keyword with both prefix and suffix

$ helm install --dry-run --debug myprefix-policy-reporter-mysuffix policy-reporter | grep "\-backend"
            - -backend=http://myprefix-policy-reporter-mysuffix:8080
$ helm template myprefix-policy-reporter-mysuffix  policy-reporter -s templates/service.yaml | yq ".metadata.name"
"myprefix-policy-reporter-mysuffix"

ReleaseName = does not contain policy-reporter keyword.

$ helm install --dry-run --debug alternative-name policy-reporter | grep "\-backend"
            - -backend=http://alternative-name-policy-reporter:8080
$ helm template alternative-name policy-reporter -s templates/service.yaml | yq ".metadata.name"
"alternative-name-policy-reporter"            

m-yosefpor and others added 4 commits October 18, 2021 23:26
Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>
Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>
Signed-off-by: Mohammad Yosefpor <myusefpur@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1356826593

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.357%

Totals Coverage Status
Change from base Build 1356375011: 0.0%
Covered Lines: 1583
Relevant Lines: 1714

💛 - Coveralls

@fjogeleit fjogeleit merged commit f75da42 into kyverno:main Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants