Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history
commit 0b698cea7230e63913dc174f7d290b2251241bad
Author: David Meyer <dihm@users.noreply.github.com>
Date:   Fri Feb 9 10:22:53 2024 -0500

    Merge pull request #64 from dihm/update_release_workflow

    Version bump gh actions to update node.js to 20

commit 332228533d61b80613748dbaab8a1e3a0d109e72
Author: David Meyer <dihm@users.noreply.github.com>
Date:   Fri Feb 9 08:02:55 2024 -0500

    Merge pull request #61 from carterturn/carterturn-dropdown-cleaning

    Remove shot from "select markers" drop down when shot is removed

commit 5dd5c5dd943b0acecac624709b6b79a0b42409b0
Author: David Meyer <dihm@users.noreply.github.com>
Date:   Fri Feb 9 07:45:40 2024 -0500

    Merge pull request #63 from dihm/setuptools_scm_fix

    Ensure `release-branch-semver` is used.
  • Loading branch information
dihm committed Feb 9, 2024
1 parent 2504b18 commit 7cc617b
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 14 deletions.
20 changes: 10 additions & 10 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
if: github.repository == 'labscript-suite/runviewer' && (github.event_name != 'create' || github.event.ref_type != 'branch')
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand All @@ -73,7 +73,7 @@ jobs:
run: git tag -d $(git tag --points-at HEAD)

- name: Install Python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}
architecture: ${{ matrix.arch }}
Expand All @@ -93,7 +93,7 @@ jobs:
- name: Upload Artifact
if: strategy.job-index == 0 || (env.PURE == 'false' && runner.os != 'Linux')
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
path: ./dist
Expand All @@ -111,7 +111,7 @@ jobs:
- name: Install Miniconda
if: matrix.conda
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true
python-version: ${{ matrix.python }}
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
- name: Upload Artifact
if: matrix.conda
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: conda_packages
path: ./conda_packages
Expand All @@ -153,7 +153,7 @@ jobs:
steps:
- name: Checkout
if: env.PURE == 'false'
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

Expand All @@ -170,7 +170,7 @@ jobs:

- name: Upload Artifact
if: env.PURE == 'false'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dist
path: dist/*manylinux*.whl
Expand All @@ -182,13 +182,13 @@ jobs:
steps:

- name: Download Artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: dist
path: ./dist

- name: Download Artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: conda_packages
path: ./conda_packages
Expand Down Expand Up @@ -226,7 +226,7 @@ jobs:
password: ${{ secrets.pypi }}

- name: Install Miniconda
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
auto-update-conda: true

Expand Down
6 changes: 4 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
[build-system]
requires = ["setuptools", "wheel", "setuptools_scm", "cython"]
build-backend = "setuptools.build_meta"
requires = ["setuptools>=64", "wheel", "setuptools_scm>=8", "cython"]
build-backend = "setuptools.build_meta"

[tool.setuptools_scm]
3 changes: 3 additions & 0 deletions runviewer/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,9 @@ def on_remove_shots(self, confirm=True):
# unselect shot
item.setCheckState(Qt.Unchecked)
shutter_item.setCheckState(Qt.Unchecked)
# remove shot from markers list
shot_combobox_index = self.ui.markers_comboBox.findText(os.path.basename(shot.path))
self.ui.markers_comboBox.removeItem(shot_combobox_index)
# remove row
self.shot_model.removeRow(row)
del shot
Expand Down
2 changes: 1 addition & 1 deletion runviewer/__version__.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import importlib_metadata

VERSION_SCHEME = {
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "guess-next-dev"),
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "release-branch-semver"),
"local_scheme": os.getenv("SCM_LOCAL_SCHEME", "node-and-date"),
}

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from setuptools import setup

VERSION_SCHEME = {
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "guess-next-dev"),
"version_scheme": os.getenv("SCM_VERSION_SCHEME", "release-branch-semver"),
"local_scheme": os.getenv("SCM_LOCAL_SCHEME", "node-and-date"),
}

Expand Down

0 comments on commit 7cc617b

Please sign in to comment.