Remove shot from "select markers" drop down when shot is removed #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this fixes the issue. Agreed that there is no worry about changing workflow or anything. Merging. |
|
Thanks for the Fix! |
dihm
added a commit
that referenced
this pull request
Feb 9, 2024
commit 0b698cea7230e63913dc174f7d290b2251241bad
Author: David Meyer <dihm@users.noreply.github.com>
Date: Fri Feb 9 10:22:53 2024 -0500
Merge pull request #64 from dihm/update_release_workflow
Version bump gh actions to update node.js to 20
commit 332228533d61b80613748dbaab8a1e3a0d109e72
Author: David Meyer <dihm@users.noreply.github.com>
Date: Fri Feb 9 08:02:55 2024 -0500
Merge pull request #61 from carterturn/carterturn-dropdown-cleaning
Remove shot from "select markers" drop down when shot is removed
commit 5dd5c5dd943b0acecac624709b6b79a0b42409b0
Author: David Meyer <dihm@users.noreply.github.com>
Date: Fri Feb 9 07:45:40 2024 -0500
Merge pull request #63 from dihm/setuptools_scm_fix
Ensure `release-branch-semver` is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request attempts to resolve issue #44 by removing shots from the "select markers" drop down when the shot is removed from runviewer.
It successfully avoids issues with shots being loaded, deleted, and loaded again.
However, this PR does change the behavior of runviewer in that previously loaded shots are no longer visible (greyed out) in the "select markers" drop down. In my opinion, the new behavior is acceptable, and---since the entries for deleted shots are greyed out---it should not impact workflows.
The case of loading the same shot twice, the removing one or both also seems to be handled correctly.