-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ArgumentMapper
to fix bugs in ARM.
#731
Conversation
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.409 ± 0.048 | 11.342 | 11.463 | 23.75 ± 0.10 |
cairo-native (embedded AOT) |
1.569 ± 0.008 | 1.558 | 1.580 | 3.26 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.658 ± 0.017 | 1.631 | 1.681 | 3.45 ± 0.04 |
cairo-native (standalone AOT) |
0.656 ± 0.006 | 0.652 | 0.669 | 1.37 ± 0.01 |
cairo-native (standalone AOT with -march=native) |
0.480 ± 0.001 | 0.480 | 0.481 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
10.785 ± 0.029 | 10.745 | 10.816 | 1322.56 ± 14.27 |
cairo-native (embedded AOT) |
1.161 ± 0.006 | 1.147 | 1.169 | 142.34 ± 1.67 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.174 ± 0.011 | 1.148 | 1.190 | 144.02 ± 2.05 |
cairo-native (standalone AOT) |
0.008 ± 0.000 | 0.008 | 0.009 | 1.04 ± 0.02 |
cairo-native (standalone AOT with -march=native) |
0.008 ± 0.000 | 0.008 | 0.008 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.950 ± 0.012 | 1.932 | 1.972 | 29.38 ± 0.19 |
cairo-native (embedded AOT) |
1.305 ± 0.010 | 1.289 | 1.322 | 19.66 ± 0.16 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
1.479 ± 0.010 | 1.461 | 1.488 | 22.27 ± 0.15 |
cairo-native (standalone AOT) |
0.107 ± 0.000 | 0.107 | 0.107 | 1.62 ± 0.00 |
cairo-native (standalone AOT with -march=native) |
0.066 ± 0.000 | 0.066 | 0.067 | 1.00 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 91.68% 91.65% -0.04%
==========================================
Files 118 120 +2
Lines 32642 32365 -277
==========================================
- Hits 29929 29665 -264
+ Misses 2713 2700 -13 ☔ View full report in Codecov by Sentry. |
…the felt value on `fmt::Debug` instead of its montgomery form limbs.
🐐 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!!!!!! 🚀 , I left some comments, most of them are about adding some docs on the AbiArgument implementations.
to_jit()
for arrays (we didn't notice because we weren't using it before).ArgumentMapper
with a more intuitive system that can integrate multiple architectures easily.Failed to deserialize param #1
error.print_felt252
.JitValue::Felt(_)
'sstd::fmt::Debug
implementation print the real value instead of its Montgomery form limbs.Checklist