set-output deprecation changed how multilines are handled
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2022 13:35
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
internalsystemerror
force-pushed
the
fix-tags-needing-multiline
branch
from
b0f2325 to
179df9e
Compare
|
Rebased using #164 to allow CI to pass |
…ltiline Signed-off-by: Gary Lockett <gary@creativecow.uk>
Xerkus
reviewed
Dec 19, 2022
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Xerkus
approved these changes
Dec 19, 2022
weierophinney
approved these changes
Dec 19, 2022
Signed-off-by: Gary Lockett <gary@creativecow.uk>
|
Nasty one: good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several tags were being created that were invalid e.g.
v1%0A1.21.0. It seems that when set-output was deprecated, github changed how multiline strings were handled. This PR should fix that issue according to: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#multiline-strings