Extend exclude with php and dependencies settings
#184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
reviewed
Feb 8, 2023
froschdesign
reviewed
Feb 8, 2023
boesing
force-pushed
the
feature/exclude-php-and-dependencies
branch
from
ef05689 to
e0d6d97
Compare
|
@internalsystemerror is the CI failure related to what you fixed in #190 ? |
|
It looks like the only issue here is that it's no longer adding the |
boesing
force-pushed
the
feature/exclude-php-and-dependencies
branch
from
e0d6d97 to
183a40c
Compare
|
@boesing @internalsystemerror should I rebase and release this to |
|
It is not properly working yet, please ignore this for any release. I'll handle this once I find some time to work on this. There is no pressure on this topic and no high need (at least for me) as of now 👍🏼 |
|
Ok, just beware that it will go into |
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This fixes the problem that the job name does not match for tools due to the fact that the name already contains the human-readable name containing the version and dependencies string. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/exclude-php-and-dependencies
branch
from
ecfd879 to
5c3b655
Compare
The exclusion strategy, when it was introduced, was meant to handle exact job names. By having the new feature of excluding tool names as well, we should still support the fill job.name as well so that we can still properly exclude jobs based on the initial exclusion strategy. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…iguration` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
With one of the newer versions of the matrix action, `test.env` files were introduced and thus have to be added to the new test cases as well. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This allows us to reference to that definition which eases the usage in several parts of the configuration. Having the list of supported PHP versions maintained in more than one location may become annoying and thus this changes makes a lot of sense. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
This was introduced in a more recent matrix version and thus was missing the expected matrix from the initial version of this feature. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
… from `.laminas-ci.json` reflects proper PHP version Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Stable PHP should represent an actual PHP version and thus `lowest` and `latest` or even wildcard references make no sense. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
… `php` enum values Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
… match, not `all` Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
…d `php` specific enum strings Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/exclude-php-and-dependencies
branch
from
4bad2af to
7f557d2
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Due to the fact that there is no `composer.lock` file available, the matrix will not generate any `locked` jobs. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces the ability to exclude specific jobs for specific PHP and/or composer dependency sets.
Fixes #93