Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8.0 support #117

Merged
merged 6 commits into from
Jan 26, 2021
Merged

Add PHP 8.0 support #117

merged 6 commits into from
Jan 26, 2021

Conversation

bfoosness
Copy link
Contributor

Q A
New Feature yes

Description

Close #114

snapshotpl
snapshotpl reviewed Dec 10, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@clementmas clementmas mentioned this pull request Dec 16, 2020
Closed
@clementmas
Copy link

Hey guys, what's the status on this PR? Can it be merged?

@bfoosness
Copy link
Contributor Author

Hey guys, what's the status on this PR? Can it be merged?

This PR is blocked for the moment because there are still a few Laminas dependencies that haven't been updated to support PHP 8.0 yet.

@clementmas clementmas mentioned this pull request Jan 3, 2021
Merged
@Ocramius Ocramius added this to the 2.13.0 milestone Jan 17, 2021
@bfoosness
Copy link
Contributor Author

I think laminas/laminas-crypt is the only remaining dependency that needs to support PHP 8.

This was referenced Jan 18, 2021
Merged
Closed
@bfoosness
Update composer.json and fix unit tests.
954b7d4 
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
@bfoosness
Run vendor/bin/phpunit --migrate-configuration
06b8118 
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
@bfoosness
Update .travis.yml.
3fab60c 
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
@bfoosness
Revert schema location.
e7137e5 
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
@bfoosness
Update .travis.yml to use PHP 8.0 instead of nightly.
4ac25df 
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
@bfoosness
Update laminas/laminas-config to 3.4, which support PHP 8.
3c1cbc7 
Signed-off-by: Brent Foosness <bfoosness@users.noreply.github.com>
Ocramius
Ocramius requested changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to check if we can drop --ignore-platform-reqs before merging

.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@Ocramius Ocramius mentioned this pull request Jan 26, 2021
Closed
Ocramius
Ocramius approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius self-assigned this Jan 26, 2021
@Ocramius Ocramius merged commit df3bfd7 into laminas:2.13.x Jan 26, 2021
@bfoosness bfoosness deleted the php-8.0 branch January 26, 2021 13:36
@Ocramius Ocramius mentioned this pull request Jan 26, 2021
Merged
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this pull request May 24, 2023
@Ocramius
Merge pull request laminas#117 from bfoosness/php-8.0
8c32fa7 
Add PHP 8.0 support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapshotpl snapshotpl snapshotpl left review comments

@glensc glensc glensc left review comments

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

PHP 8.0 support
5 participants
@bfoosness @clementmas @Ocramius @glensc @snapshotpl