Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Resolve duplicate data provider key #129

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Tests: Resolve duplicate data provider key #129

merged 1 commit into from
Jan 26, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 18, 2021 •
edited
Loading

Q A
Documentation yes/no
Bugfix yes
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes

Description

Fixes duplicate test name:

And also:

1) Error
The data provider specified for LaminasTest\Mail\Header\ContentDispositionTest::testParameterWrapping is invalid.
PHPUnit\Framework\InvalidDataProviderException: The key "With two ordered items" has already been defined in the data provider "parameterWrappingProvider".

Needed for phphunit 9 compatibility.

@glensc
Resolve duplicate data provider key
09ca73a 
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
@glensc glensc mentioned this pull request Jan 18, 2021
Merged
@glensc glensc changed the title Resolve duplicate data provider key Tests: Resolve duplicate data provider key Jan 18, 2021
@glensc glensc mentioned this pull request Jan 20, 2021
Closed
@glensc
Copy link
Contributor Author

glensc commented Jan 21, 2021

cc @Ocramius

@glensc
Copy link
Contributor Author

glensc commented Jan 26, 2021

@Ocramius can you merge this trivial change? blocks two phpunit9 merge requests here. ignore the coveralls job failure: "Coverage remained the same at 62.256%"

Ocramius
Ocramius approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius added this to the 2.13.0 milestone Jan 26, 2021
@Ocramius Ocramius added the Bug Something isn't working label Jan 26, 2021
@Ocramius Ocramius self-assigned this Jan 26, 2021
@Ocramius Ocramius merged commit 42ed1cb into laminas:2.13.x Jan 26, 2021
@glensc glensc deleted the dataprovider-name-conflict branch January 26, 2021 15:26
artemii-karkusha pushed a commit to artemii-karkusha/laminas-mail that referenced this pull request May 24, 2023
@Ocramius
Merge pull request laminas#129 from glensc/dataprovider-name-conflict
cf36248 
Tests: Resolve duplicate data provider key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @Ocramius