Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Eliminate Global Variables for Improved Code Maintainability #4206

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

edwinjosechittilappilly
Copy link
Collaborator

  • Replaced global variables with local variables or class attributes.
  • Enhanced code readability and reduced potential side effects.

- Replaced global variables with local variables or class attributes.
- Enhanced code readability and reduced potential side effects.
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 18, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2024
@edwinjosechittilappilly
Copy link
Collaborator Author

edwinjosechittilappilly commented Oct 18, 2024

@carlosrcoelho @Cristhianzl @jordanrfrazier

should I merge this into https://github.com/langflow-ai/langflow/tree/v1.0.19.1 ?
or should I rebase it with the 1.0.19.1 and merge the changes?

@jordanrfrazier
Copy link
Collaborator

I would think we should treat release branches similar to main, so merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants