Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Eliminate Global Variables for Improved Code Maintainability #4206

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor: Eliminate Global Variables for Improved Code Maintainability #4206

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa7f024
Refactor: Eliminate Global Variables for Improved Code Maintainability
edwinjosechittilappilly Oct 18, 2024
e3feaeb
Merge branch 'main' into fix-create-data
edwinjosechittilappilly Oct 18, 2024
87723ec
Merge branch 'main' into fix-create-data
edwinjosechittilappilly Oct 18, 2024
128aa68
Merge branch 'main' into fix-create-data
edwinjosechittilappilly Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/backend/base/langflow/components/prototypes/CreateData.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@
from langflow.schema import Data
from langflow.schema.dotdict import dotdict

MAX_NUMBER_OF_FIELDS = 15


class CreateDataComponent(Component):
display_name: str = "Create Data"
description: str = "Dynamically create a Data with a specified number of fields."
name: str = "CreateData"
MAX_FIELDS = 15 # Define a constant for maximum number of fields

inputs = [
IntInput(
Expand All @@ -22,7 +21,7 @@ class CreateDataComponent(Component):
info="Number of fields to be added to the record.",
real_time_refresh=True,
value=1,
range_spec=RangeSpec(min=1, max=15, step=1, step_type="int"),
range_spec=RangeSpec(min=1, max=MAX_FIELDS, step=1, step_type="int"),
),
MessageTextInput(
name="text_key",
Expand Down Expand Up @@ -50,10 +49,11 @@ def update_build_config(self, build_config: dotdict, field_value: Any, field_nam
except ValueError:
return build_config
existing_fields = {}
if field_value_int > MAX_NUMBER_OF_FIELDS:
build_config["number_of_fields"]["value"] = MAX_NUMBER_OF_FIELDS
if field_value_int > self.MAX_FIELDS:
build_config["number_of_fields"]["value"] = self.MAX_FIELDS
msg = (
f"Number of fields cannot exceed {MAX_NUMBER_OF_FIELDS}. Try using a Component to combine two Data."
f"Number of fields cannot exceed {self.MAX_FIELDS}. "
"Please adjust the number of fields to be within the allowed limit."
)
raise ValueError(msg)
if len(build_config) > len(default_keys):
Expand Down
Loading