Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vue highlight support #1326

Merged
merged 5 commits into from
Sep 29, 2022
Merged

add vue highlight support #1326

merged 5 commits into from
Sep 29, 2022

Conversation

xiaoxin-sky
Copy link
Contributor

Hi, I'm add the vue syntax highlight. But the script、style tag is wip. I will continue to work to improve it.

@bugadani
Copy link
Contributor

bugadani commented Sep 23, 2022

Some of the crate metadata is incorrect - The "repository" on https://crates.io/crates/tree-sitter-vue points at a page that does not exist. Also, please rebase your changes on master, most of the commits should have been merged already I think.

@bugadani bugadani added the A-syntax Area: syntax highlighting label Sep 23, 2022
@xiaoxin-sky
Copy link
Contributor Author

Some of the crate metadata is incorrect - The "repository" on https://crates.io/crates/tree-sitter-vue points at a page that does not exist. Also, please rebase your changes on master, most of the commits should have been merged already I think.

Sorry, I will change. But the tree-sitter-vue repo seems not active, I create a pr for tree-sitter-vue in order to support lapce. but the tree-sitter-vue author doesn't seem to maintain. So, which repo does I write in the repository of crate metadata?The
Of the original author repository repository or my repo for the original author?

@xiaoxin-sky
Copy link
Contributor Author

I have modified the metadata of the repository.

@xiaoxin-sky xiaoxin-sky reopened this Sep 25, 2022
Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the druid dependency was reformatted but no need to delay this PR on that, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntax Area: syntax highlighting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants