Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Laravel 10 #131

Merged
merged 8 commits into from
Aug 8, 2023
Merged

feat: allow Laravel 10 #131

merged 8 commits into from
Aug 8, 2023

Conversation

77web
Copy link
Contributor

@77web 77web commented Feb 20, 2023

Now that Laravel 10 has been released, we need Laravel 10 compatible version of laravel-doctrine packages :)
orm and extensions have already PRs, so I want to try Laravel 10 along with migrations.

Please review and try, friends.
Thank you.

composer.json Outdated Show resolved Hide resolved
"illuminate/config": "^6.0|^7.0|^8.0|^9.0",
"illuminate/contracts": "^6.0|^7.0|^8.0|^9.0",
"illuminate/console": "^6.0|^7.0|^8.0|^9.0",
"laravel-doctrine/orm": "^1 | ^2@dev"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can revert this change now (and remove the repositories part) :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the PR in extensions repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should still allow 1^, so ^1 | ^2@dev is correct here :)

@eigan eigan merged commit 9c580e6 into laravel-doctrine:3.x Aug 8, 2023
@77web 77web deleted the feat/laravel-10 branch August 8, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants