Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow laravel 10 for laravel-doctrine v2.0 #557

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

77web
Copy link
Contributor

@77web 77web commented Aug 1, 2023

refs #542

Tests successfully passed in my local PC with Laravel10.

Changes proposed in this pull request:

  • allow laravel10 as dependency

@77web 77web changed the title [FEATURE] allow laravel 10 [FEATURE] allow laravel 10 for laravel-doctrine v2.0 Aug 1, 2023
77web added a commit to 77web/laravel-doctrine-migrations that referenced this pull request Aug 1, 2023
@77web
Copy link
Contributor Author

77web commented Aug 2, 2023

combination of #557 + laravel-doctrine/extensions#64 + laravel-doctrine/migrations#131 worked fined in my project 😄

@77web 77web mentioned this pull request Aug 2, 2023
Closed
10 tasks
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ad94c82) 66.88% compared to head (6377218) 66.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.0     #557   +/-   ##
=========================================
  Coverage     66.88%   66.88%           
  Complexity      563      563           
=========================================
  Files            83       83           
  Lines          1806     1806           
=========================================
  Hits           1208     1208           
  Misses          598      598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eigan eigan merged commit 0133a69 into laravel-doctrine:2.0 Aug 8, 2023
@eigan
Copy link
Member

eigan commented Aug 8, 2023

Thanks :)

@77web 77web deleted the 2.0-allow-laravel10 branch August 8, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants