[5.4 + LTS] Fix tests code coverage config. #19609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieutu
changed the title
|
Damn, I should have figured it out. Thanks for the patch. |
|
@egorpe and thank you for showing me that the problem was not just for me! |
|
@taylorotwell Shouldn't we merge that on 5.1 and master too ? |
mathieutu
added a commit
to mathieutu/framework
that referenced
this pull request
Jun 19, 2017
* commit '05060b183dd09cee6dce498da5afde9e66fd1a29': Apply fixes from StyleCI (laravel#19659) [5.4] Add ability to remove a global scope with another global scope (laravel#19657) [5.4] Add fresh method on Eloquent\Collection. (laravel#19616) support multiple fields to validateDifferent (laravel#19637) escape default value of yield blade directive (laravel#19643) [5.4] Add "avg" and "average" to higher order proxy. (laravel#19628) tagged v5.4.27 release notes version Add missing dependency. (laravel#19623) update timestamp on soft delete only when its used (laravel#19627) Add new `diffAssoc()` method to collection (laravel#19604) Fix tests code coverage config. (laravel#19609) # Conflicts: # src/Illuminate/Database/Eloquent/Collection.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
I've just seen that since.. a long time ago (don't know when exactly), the code coverage config is completely outdated, so all the views was dumped instead of lunching code coverage.
This post from @egorpe show exactly the issue:
https://laracasts.com/discuss/channels/laravel/phpunit-coverage-for-laravel-framework-spits-out-html-instead-of-running-tests
You can see the failure on his travis build:
https://travis-ci.org/egorpe/framework/jobs/241038092
This PR update the config, so the code coverage is passing now (but is actually a bit scary ^^")