Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Support passing multiple fields to "different" validation rule #19637

Merged
merged 1 commit into from
Jun 16, 2017
Merged

[5.4] Support passing multiple fields to "different" validation rule #19637

merged 1 commit into from
Jun 16, 2017

Conversation

tillkruss
Copy link
Contributor

@tillkruss tillkruss commented Jun 16, 2017 •
edited
Loading

Fails if any of the passed fields don't exist or are identical, just like it does with a single field.

I replaced isset() with is_null(), because $other is always set.

@tillkruss tillkruss changed the title Support passing multiple fields to different validation rule [5.4] Support passing multiple fields to different validation rule Jun 16, 2017
@themsaid themsaid changed the title [5.4] Support passing multiple fields to different validation rule [5.4] Support passing multiple fields to "different" validation rule Jun 16, 2017
@taylorotwell taylorotwell merged commit c29b004 into laravel:5.4 Jun 16, 2017
mathieutu added a commit to mathieutu/framework that referenced this pull request Jun 19, 2017
@mathieutu
Merge branch laravel/5.4 into features/fresh-on-collection
7f9c0f1 
* commit '05060b183dd09cee6dce498da5afde9e66fd1a29':
  Apply fixes from StyleCI (laravel#19659)
  [5.4] Add ability to remove a global scope with another global scope (laravel#19657)
  [5.4] Add fresh method on Eloquent\Collection. (laravel#19616)
  support multiple fields to validateDifferent (laravel#19637)
  escape default value of yield blade directive (laravel#19643)
  [5.4] Add "avg" and "average" to higher order proxy. (laravel#19628)
  tagged v5.4.27 release notes
  version
  Add missing dependency. (laravel#19623)
  update timestamp on soft delete only when its used (laravel#19627)
  Add new `diffAssoc()` method to collection (laravel#19604)
  Fix tests code coverage config. (laravel#19609)

# Conflicts:
#	src/Illuminate/Database/Eloquent/Collection.php
@tillkruss tillkruss deleted the validate-different branch July 21, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillkruss @taylorotwell