Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for more duration types. #115

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Conversation

dpi
Copy link
Contributor

@dpi dpi commented Sep 2, 2019

Added support for alternative intervals for edit command.

For example you can use:

Fraction of hour (Redmine style):

  • 15 minutes: tl edit FOO .25
  • 1hour 15 minutes: tl edit FOO 1.25

Minutes:

  • 30 minutes: tl edit FOO :30
  • 1 hour 30 minutes: tl edit FOO 1:30

Friendly intervals:

  • 1 hour 30 minutes: tl edit FOO 1h30m
  • 1 hour 30 minutes: tl edit FOO '1h 30m'
  • 15 minutes: tl edit FOO 900s
  • 1 day: tl edit FOO 1d

Also fixed edit command accepting invalid slot IDs without error.

@larowlan
Copy link
Owner

Could you merge master on this one @dpi

Copy link
Owner

@larowlan larowlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work mate, love the use of a utility

src/Commands/Edit.php Outdated Show resolved Hide resolved
src/Input.php Show resolved Hide resolved
src/Input.php Outdated Show resolved Hide resolved
src/Input.php Outdated Show resolved Hide resolved
src/Input.php Outdated Show resolved Hide resolved
src/Input.php Outdated Show resolved Hide resolved
@dpi
Copy link
Contributor Author

dpi commented Sep 19, 2019

@larowlan, pushed some changes

@larowlan larowlan merged commit 5efa9b7 into larowlan:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants