Added tl add command.
#116
Conversation
Sample usage: `tl add 12355 0.5` to log half an hour to ticket 12355. `tl add 12355 1 "Doin stuff"` to log an hour to ticket 12355 with comment. `tl add 12355 .25 "Daily Scrum" -s 11am` to log time for 11am scrum. `tl add 12345 1 -s 2018-12-31 11 am` to log time for specfic date. Signed-off-by: Jibran Ijaz <jibran.ijaz@gmail.com>
|
Out of interest, how does |
|
@Sam152 start time is posted to Jira as the entry time. When you click Work logs tab in Jira it shows when it was posted, in same fashion as comments. |
src/Commands/Add.php
Outdated
| $params[':comment'] = $comment; | ||
| } | ||
| $slot_id = $this->repository->insert($record, $params); | ||
| $output->writeln(sprintf('<bg=blue;fg=white;options=bold>[%s]</> Added entry for <info>%d</info>: %s [slot:<comment>%d</comment>] for <info>%s</info>.', |
There was a problem hiding this comment.
Thanks for outputting the start time in a consistent fashion since the user may be unaware how PHP interprets human date strings..
I think we should reorder message by importance of information in conversational tone:
.... Added entry for TICKETNUMBER:TICKETNAME on DATE for HOURS (Slot XYZ).
Slot ID is less important for add-command since its not likely user needs to reference it later.
There was a problem hiding this comment.
also, is the bg = blue a new thing? can we keep it consistent with other commands ?
There was a problem hiding this comment.
also, is the bg = blue a new thing? can we keep it consistent with other commands ?
It is same as https://github.com/larowlan/tl/blob/master/src/Commands/Start.php#L100
There was a problem hiding this comment.
@dpi let me know if it seems better now.
|
Duration arg should be reworked with the stuff from #115, if it lands first. |
|
can you merge master on this one @jibran |
src/Commands/Add.php
Outdated
| $params[':comment'] = $comment; | ||
| } | ||
| $slot_id = $this->repository->insert($record, $params); | ||
| $output->writeln(sprintf('<bg=blue;fg=white;options=bold>[%s]</> Added entry for <info>%d</info>: %s [slot:<comment>%d</comment>] for <info>%s</info>.', |
There was a problem hiding this comment.
also, is the bg = blue a new thing? can we keep it consistent with other commands ?
Signed-off-by: Jibran Ijaz <jibran.ijaz@gmail.com>
jibran
force-pushed
the
add-add-command
branch
from
98b21bd
to
d26d1c4
Compare
Switch add command to new interval utility
Signed-off-by: Jibran Ijaz <jibran.ijaz@gmail.com>
Sample usage:
tl add 12355 0.5to log half an hour to ticket 12355.tl add 12355 1 "Doin stuff"to log an hour to ticket 12355 with comment.tl add 12355 .25 "Daily Scrum" -s 11amto log time for 11am scrum.tl add 12345 1 -s 2018-12-31 11 amto log time for specfic date.Signed-off-by: Jibran Ijaz jibran.ijaz@gmail.com