feat(postgres): WIP implement COPY FROM/TO STDIN
#491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/pg-copy
branch
6 times, most recently
from
56b7d55 to
a74c414
Compare
Signed-off-by: Austin Bonander <austin@launchbadge.com>
abonander
commented
Jul 9, 2020
| /// [in this StackOverflow answer](https://stackoverflow.com/a/35319598). | ||
| /// | ||
| /// If you don't read the stream to completion, the next time the connection is used it will | ||
| /// need to read and discard all the remaining queued data, which could take some time. |
There was a problem hiding this comment.
I need to actually handle this.
abonander
commented
Jul 9, 2020
|
|
||
| match conn.stream.recv().await { | ||
| Ok(msg) => Err(err_protocol!( | ||
| "fail_with: expected ErrorResponse, got: {:?}", |
There was a problem hiding this comment.
Need to update this error message.
abonander
commented
Jul 9, 2020
| msg.format | ||
| )), | ||
| // FIXME: inspect the `DatabaseError` to make sure we're not discarding another error | ||
| Err(Error::Database(_db)) => Ok(()), |
There was a problem hiding this comment.
We shouldn't merge until this is fixed.
abonander
commented
Jul 9, 2020
| conn.wait_until_ready().await?; | ||
| conn.stream.send(Query(statement)).await?; | ||
|
|
||
| let _: CopyResponse = conn |
There was a problem hiding this comment.
Not sure if or how we want to make this available for inspection by the user.
|
Closing to clear up the PR queue but note that @abonander is still planning to work on this in the near future. |
|
@abonander Sorry to bug; is there a reason this hasn't progressed further in the past year or so, or has it just not been a priority? I would greatly appreciate the inclusion of this feature for a project I'm actively working on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36