WIP: massive refactors re: Connection/Connect/Transaction
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for getting this started. Merged and finished locally. Will push soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started as a small tangent on #491 to use
MaybeOwnedinPgCopyInbecame a refactor
MaybeOwned -> MaybePooleddue to leaked
Sendbounds regardingArc<SharedPool>containingConnect::OptionsinConnection::transaction()it exploded into removing theConnectionimpl fromTransactiondecided we could merge
Connection + Connectfound a bug that
Connection::transaction_depth()is no longer calculated correctly since transactions don't nest ownershipdecided that this didn't belong in #491 as it touched too much code