Prepare 4.7.0 release #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* installs new deviceModel into EnvironmentReporter and renames old deviceModel to deviceType * use CwSysCtl for macos model
Fix for concurrency bug in FlagStore
Prepare Version 4.1.1
…formation to struct
* Fixed build errors, fixed some unit tests * Added shell script to remove duplicate sourcery method mock * sed now matches specific pattern instead of line numbers * Add project config file containing run script step * Bump CircleCI Xcode to 11.4 * Bump CircleCI Xcode to 11.4.0 * Changed iPhone simulator in CircleCI from XS to Xs * Changed CircleCI xcodebuild from OS:latest to OS:12.4 * Testing NSURLRetryPolicy on CI * Removed DeprecatedCache from automock
Fix FlagStore to synchronize reads with writes.
…he (#96) * Added maxCachedUsers to LDConfig and UserEnvironmentFlagCache * Changed specific -1 to 0 * Added unlimited users tests
* Added startCompleteWhenFlagsReceivedTimeout which allows a timeout in seconds to be given for the completion to be fired indicating that flags have been received * Fixed doc typo, removed bad ms to second conversion * Fix previous doc typo that got copied into objc * Added serial queue to timeOutCheck to fix possible race condition * Simplified unit tests by swapping if for assertion * Simplified start timeout method name, fixed doc about timedOut return * Moved DispatchQueue off of main * Moved sync dispatchqueue from variable to func * Changed labeled queue to global queue * Added test for start timeout timing out, added doc note about start timeout and starting offline
gwhelanLD
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[4.7.0] - 2020-06-03
Added
startCompleteWhenFlagsReceivedthat accepts an additional argument specifying a maximum time to wait for flags to be received before calling the completion closure. The completion closure on this method will be passed aBoolon completion indication whether the operation timed out.This addresses issue #209.