-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
…mode (#9700)
- Loading branch information
1 parent
dfe5383
commit fdbfa78
Showing
8 changed files
with
59 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/editor/CodeMirror/editorCommands/insertLineAfter.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { EditorSelection } from '@codemirror/state'; | ||
| import createTestEditor from '../testUtil/createTestEditor'; | ||
| import insertLineAfter from './insertLineAfter'; | ||
|
|
||
| describe('insertLineAfter', () => { | ||
| test('should continue lists', async () => { | ||
| const editor = await createTestEditor( | ||
| '- This\n- is\n- a test', | ||
| EditorSelection.cursor(1), | ||
| ['BulletList'], | ||
| ); | ||
| insertLineAfter(editor); | ||
| expect(editor.state.doc.toString()).toBe([ | ||
| '- This', | ||
| '- ', | ||
| '- is', | ||
| '- a test', | ||
| ].join('\n')); | ||
| }); | ||
| }); |
23 changes: 23 additions & 0 deletions
23
packages/editor/CodeMirror/editorCommands/insertLineAfter.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { insertNewlineAndIndent } from '@codemirror/commands'; | ||
| import { insertNewlineContinueMarkup } from '@codemirror/lang-markdown'; | ||
| import { EditorSelection, SelectionRange } from '@codemirror/state'; | ||
| import { EditorView } from '@codemirror/view'; | ||
|
|
||
| const insertLineAfter = (view: EditorView) => { | ||
| const state = view.state; | ||
| view.dispatch(state.changeByRange((sel: SelectionRange) => { | ||
| const line = state.doc.lineAt(sel.anchor); | ||
| return { | ||
| range: EditorSelection.cursor(line.to), | ||
| }; | ||
| })); | ||
|
|
||
| // insertNewlineContinueMarkup does nothing if not in markdown -- we thus | ||
| // need a fallback case | ||
| const addedNewLine = insertNewlineContinueMarkup(view); | ||
| if (!addedNewLine) { | ||
| insertNewlineAndIndent(view); | ||
| } | ||
| }; | ||
|
|
||
| export default insertLineAfter; |
2 changes: 1 addition & 1 deletion
2
...tor/NoteBody/CodeMirror/utils/setupVim.ts → packages/editor/CodeMirror/util/setupVim.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters